Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

`brew install` should tell which files couldn't be linked #18303

Closed
adamv opened this Issue · 8 comments

4 participants

@adamv
Owner
Warning: Could not link git. Unlinking...
Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /usr/local
You can try again using `brew link git'

I shouldn't have to do brew link git to see which file failed; install should tell me.

(It is due to the completion monkeying around)

@adamv
Owner
Error: Could not symlink file: /Users/adamv/homebrew/Cellar/git/1.8.1.5/etc/bash_completion.d/git-completion.bash
Target /usr/local/etc/bash_completion.d/git-completion.bash already exists. You may need to delete it.

So I guess we install in a way that conflicts with bash-completion now? Seems lame.

@urdh

Yeah, I've been noticing this lately. I think there's a similar poblem with zsh stuff.

@mikemcquaid
Owner

Pretty sure this only occurs if you used a particular bad revision of Git in the past. Should be fixed for clean builds now. If there's anything obviously stupid we're doing though let me know.

@jacknagel
Collaborator

I tagged this and some other brew link related issues. I'm sure everything would benefit from turning the error handling in Pathname#make_relative_symlink into real exceptions that the UX layer can manage.

@mikemcquaid
Owner

@adamv The main problem with this is we have a file we need to install into two different places.

@adamv
Owner

@mikemcquaid that's what "cp" is for.

@mikemcquaid
Owner

@adamv That's what I've done here and it makes :crying_cat_face:

@adamv
Owner

The conflicting file is show in verbose mode (or possibly verbose+debug) mode. Should still show in the normal case though:

$ brew install gsmartcontrol
==> Downloading http://download.berlios.de/gsmartcontrol/gsmartcontrol-0.8.7.tar.bz2
Already downloaded: /usr/local/homebrew-cache/gsmartcontrol-0.8.7.tar.bz2
==> Patching
patching file src/applib/cmdex_sync_gui.cpp
patching file src/gsc_init.cpp
==> ./configure --prefix=/Users/vandenbe/brew/Cellar/gsmartcontrol/0.8.7
==> make
==> make install
Warning: Could not link gsmartcontrol. Unlinking...
Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /Users/vandenbe/brew
You can try again using `brew link gsmartcontrol'
==> Summary
/Users/vandenbe/brew/Cellar/gsmartcontrol/0.8.7: 42 files, 2.6M, built in 38 seconds
@adamv adamv closed this in d8d41cc
@nddrylliog nddrylliog referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@handyman5 handyman5 referenced this issue from a commit in handyman5/homebrew
@adamv adamv Show conflicting files on install if linking fails
Closes #18303.
Closes #20726.
bf12725
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.