Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

`brew install` should tell which files couldn't be linked #18303

Closed
adamv opened this Issue · 8 comments

4 participants

Adam Vandenberg Simon Sigurdhsson Mike McQuaid Jack Nagel
Adam Vandenberg
Owner
Warning: Could not link git. Unlinking...
Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /usr/local
You can try again using `brew link git'

I shouldn't have to do brew link git to see which file failed; install should tell me.

(It is due to the completion monkeying around)

Adam Vandenberg
Owner
Error: Could not symlink file: /Users/adamv/homebrew/Cellar/git/1.8.1.5/etc/bash_completion.d/git-completion.bash
Target /usr/local/etc/bash_completion.d/git-completion.bash already exists. You may need to delete it.

So I guess we install in a way that conflicts with bash-completion now? Seems lame.

Simon Sigurdhsson

Yeah, I've been noticing this lately. I think there's a similar poblem with zsh stuff.

Mike McQuaid
Owner

Pretty sure this only occurs if you used a particular bad revision of Git in the past. Should be fixed for clean builds now. If there's anything obviously stupid we're doing though let me know.

Jack Nagel
Owner

I tagged this and some other brew link related issues. I'm sure everything would benefit from turning the error handling in Pathname#make_relative_symlink into real exceptions that the UX layer can manage.

Mike McQuaid
Owner

@adamv The main problem with this is we have a file we need to install into two different places.

Adam Vandenberg
Owner

@mikemcquaid that's what "cp" is for.

Mike McQuaid
Owner

@adamv That's what I've done here and it makes :crying_cat_face:

Adam Vandenberg
Owner

The conflicting file is show in verbose mode (or possibly verbose+debug) mode. Should still show in the normal case though:

$ brew install gsmartcontrol
==> Downloading http://download.berlios.de/gsmartcontrol/gsmartcontrol-0.8.7.tar.bz2
Already downloaded: /usr/local/homebrew-cache/gsmartcontrol-0.8.7.tar.bz2
==> Patching
patching file src/applib/cmdex_sync_gui.cpp
patching file src/gsc_init.cpp
==> ./configure --prefix=/Users/vandenbe/brew/Cellar/gsmartcontrol/0.8.7
==> make
==> make install
Warning: Could not link gsmartcontrol. Unlinking...
Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /Users/vandenbe/brew
You can try again using `brew link gsmartcontrol'
==> Summary
/Users/vandenbe/brew/Cellar/gsmartcontrol/0.8.7: 42 files, 2.6M, built in 38 seconds
Adam Vandenberg adamv closed this in d8d41cc
Amos Wenger (old) nddrylliog referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
Adam Compton handyman5 referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.