Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

mtr causes brew doctor to say there's unresolved dependencies with --no-gtk #8957

Closed
nelsonjchen opened this Issue · 5 comments

3 participants

@nelsonjchen

I've just installed homebrew and after installing mtr with:

brew install mtr --no-gtk

, brew doctor claims there are missing dependencies for mtr.

mtr: pkg-config, gettext, libffi, libiconv, glib, jpeg, libtiff, jasper, gdk-pixbuf, pango, atk, gtk+

MTR works just fine and it seems all those dependencies are of GTK.

@adamv
Owner

brew missing (which doctor is using) only checks against the "default" depends_on set.

Need to update it to check against the installed-options set, now that we are writing install receipts.

@jacknagel
Collaborator

This is made somewhat difficult by the fact that dependencies are determined when the class is loaded, so just pushing the used_options onto ARGV isn't enough.

@jacknagel
Collaborator

Also note that if you say brew missing mtr --no-gtk it does the right thing.

@adamv
Owner

Brew missing should take the install receipt into account when detecting dependencies. Problem with current brew implementation is that we'd have to fake out ARGV per formula.

In my "options refactor", there's a new build_options (don't like the name) ivar in Formula that is preferred over ARGV for things like "build head". Could mass-migrate all option checking in that branch, and move away from direct usage of the ARGV global in formulae themselves.

@adamv
Owner

Should be addressed by the work in #13923.

@adamv adamv closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.