Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Library/Homebrew/cmd/doctor.rb has a character that breaks the parser #10962

Closed
wants to merge 1 commit into from

3 participants

Michael Nygard Max Howell Misty De Meo
Michael Nygard

Looks like a "smart" apostrophe got checked in to a text block. This was causing errors like "invalid multibyte char".

Max Howell
Owner

Works here, why doesn't it work for you?

Max Howell mxcl closed this pull request from a commit
Michael Nygard mtnygard Remove invalid character for UTF-8
Closes #10962.

Signed-off-by: Max Howell <max@methylblue.com>
6a76f9b
Max Howell mxcl closed this in 6a76f9b
Michael Nygard

I have no idea why it didn't work for me, but does for you.

Max Howell
Owner

Oh well, was just hoping to understand the issue. Pulled. Thanks.

Misty De Meo
Owner

I'm guessing your /usr/bin/ruby is a symlink to Ruby 1.9.x, @mtnygard. "invalid multibyte char" is a 1.9-specific error, since 1.8 doesn't really grok encodings. (More specifically: Ruby 1.9 strings have a builtin encoding, and Ruby will throw an exception if a string contains characters which are invalid in that string's encoding. That string was being interpreted as US-ASCII, and is not a valid ASCII character.)

We develop Homebrew against Ruby 1.8 since that's what comes with the OS, and don't recommend changing /usr/bin/ruby. Doesn't mean we don't fix 1.9 issues when they come up though. ;)

Martin Wilhelmi mnin referenced this pull request from a commit
Michael Nygard mtnygard Remove invalid character for UTF-8
Closes #10962.

Signed-off-by: Max Howell <max@methylblue.com>
db59f03
Charlie Sharpsteen Sharpie referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Konstantin Shabanov etehtsea referenced this pull request from a commit in etehtsea/homebrew
Michael Nygard mtnygard Remove invalid character for UTF-8
Closes #10962.

Signed-off-by: Max Howell <max@methylblue.com>

Conflicts:

	Library/Homebrew/cmd/doctor.rb
1e38b24
Jeremy Voorhis jvoorhis referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Maria Neise MNeise referenced this pull request from a commit
Michael Nygard mtnygard Remove invalid character for UTF-8
Closes #10962.

Signed-off-by: Max Howell <max@methylblue.com>
bab6b1d
Christopher Coco cacoco referenced this pull request from a commit
Michael Nygard mtnygard Remove invalid character for UTF-8
Closes #10962.

Signed-off-by: Max Howell <max@methylblue.com>
890f383
Elliot Saba staticfloat referenced this pull request from a commit in staticfloat/homebrew
Michael Nygard mtnygard Remove invalid character for UTF-8
Closes #10962.

Signed-off-by: Max Howell <max@methylblue.com>
b48bd76
Julien Blanchard julienXX referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Charlie Sharpsteen Sharpie referenced this pull request from a commit in Sharpie/homebrew
Michael Nygard mtnygard Remove invalid character for UTF-8
Closes #10962.

Signed-off-by: Max Howell <max@methylblue.com>
91f6a63
snakeyroc3 snakeyroc3 referenced this pull request from a commit in snakeyroc3/homebrew
Michael Nygard mtnygard Remove invalid character for UTF-8
Closes #10962.

Signed-off-by: Max Howell <max@methylblue.com>
d75329a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 15, 2012
  1. Michael Nygard
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  Library/Homebrew/cmd/doctor.rb
2  Library/Homebrew/cmd/doctor.rb
View
@@ -220,7 +220,7 @@ def check_cc
You have no /usr/bin/cc.
This means you probably can't build *anything*. You need to install the CLI
Tools for Xcode. You can either download this from http://connect.apple.com/
- or install them from inside Xcodes preferences. Homebrew does not require
+ or install them from inside Xcode's preferences. Homebrew does not require
all of Xcode! You only need the CLI tools package!
EOS
end
Something went wrong with that request. Please try again.