Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

itex2MML v1.4.9 #11208

Closed
wants to merge 1 commit into from

3 participants

@stepheneb

use versioned archive for itex2mml

This is a fix for the closed pull request: #7441

Library/Formula/itex2mml.rb
@@ -0,0 +1,57 @@
+require 'formula'
+
+# From: Jacques Distler <distler@golem.ph.utexas.edu>
+# You can always find the latest version by checking
+# http://golem.ph.utexas.edu/~distler/code/itexToMML/view/head:/itex-src/itex2MML.h
+# The corresponding versioned archive is
+# http://golem.ph.utexas.edu/~distler/blog/files/itexToMML-x.x.x.tar.gz
+
+class Itex2mml < Formula
+ url 'http://golem.ph.utexas.edu/~distler/blog/files/itexToMML-1.4.9.tar.gz'
+ homepage 'http://golem.ph.utexas.edu/~distler/blog/itex2MML.html'
+ md5 '156a20b8d04e85f07cf4eb992e0756fb'
+
+ version '1.4.9'
@jacknagel Owner

Remove this; Homebrew can glean it from the URL.

done

The reason I put this here is that the download link on this page is ONLY to an unversioned archive: http://golem.ph.utexas.edu/~distler/blog/itex2MML.html -- there is a version mentioned in text on the page but it is out-of-date.

The directory: http://golem.ph.utexas.edu/~distler/blog/files/ is not listable so I couldn't just see if there were versioned archives there.

I put those comments there because I fifn't think I would remember how to get the version number if I just went to Jacques page.

@jacknagel Owner

No, the comments were fine. I was talking about the explicit version declaration: version '1.4.9' is not necessary because Homebrew can determine it from the url field.

brew audit <formula> will warn about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Library/Formula/itex2mml.rb
((4 lines not shown))
+# You can always find the latest version by checking
+# http://golem.ph.utexas.edu/~distler/code/itexToMML/view/head:/itex-src/itex2MML.h
+# The corresponding versioned archive is
+# http://golem.ph.utexas.edu/~distler/blog/files/itexToMML-x.x.x.tar.gz
+
+class Itex2mml < Formula
+ url 'http://golem.ph.utexas.edu/~distler/blog/files/itexToMML-1.4.9.tar.gz'
+ homepage 'http://golem.ph.utexas.edu/~distler/blog/itex2MML.html'
+ md5 '156a20b8d04e85f07cf4eb992e0756fb'
+
+ version '1.4.9'
+
+ def install
+ Dir.chdir("itex-src") do
+ system "make"
+ system "mkdir -p #{bin}"
@jacknagel Owner

bin.mkpath

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Library/Formula/itex2mml.rb
((5 lines not shown))
+# http://golem.ph.utexas.edu/~distler/code/itexToMML/view/head:/itex-src/itex2MML.h
+# The corresponding versioned archive is
+# http://golem.ph.utexas.edu/~distler/blog/files/itexToMML-x.x.x.tar.gz
+
+class Itex2mml < Formula
+ url 'http://golem.ph.utexas.edu/~distler/blog/files/itexToMML-1.4.9.tar.gz'
+ homepage 'http://golem.ph.utexas.edu/~distler/blog/itex2MML.html'
+ md5 '156a20b8d04e85f07cf4eb992e0756fb'
+
+ version '1.4.9'
+
+ def install
+ Dir.chdir("itex-src") do
+ system "make"
+ system "mkdir -p #{bin}"
+ system "make install prefix=#{prefix}"
@jacknagel Owner

Needs to be a list on the off chance prefix has spaces in it.

system "make", "install", "prefix=#{prefix}"

Also, you should be able to stick BINDIR=#{bin} on the end there and avoid the patch.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@stepheneb

Jack, thanks for reviewing my pull request and providing feedback.

I've implemented all your suggestions.

Should I rebase these together and force push an update to my itex2mml branch?

I know I can combine my commits into one but don't know what github's pull management system will make of a rebase and force push.

@adamv
Owner

As long as you are in a branch, GitHub will do the right thing.

@stepheneb

ok ... I just rebased it all back to one commit

@stepheneb

The latest removes the explicit version number and adds the comments back in about how to actually find the versioned archive on Jacque's page.

brew audit itex2mml reports nothing.

@adamv
Owner

I get a linking warning (though it seems to install):

$ brew install -v itex2mml 
==> Downloading http://golem.ph.utexas.edu/~distler/blog/files/itexToMML-1.4.9.tar.gz
Already downloaded: /usr/local/homebrew-cache/itex2mml-1.4.9.tar.gz
/usr/bin/tar xf /usr/local/homebrew-cache/itex2mml-1.4.9.tar.gz
==> make
make 
-e:1: Use RbConfig instead of obsolete and deprecated Config.
-e:1: Use RbConfig instead of obsolete and deprecated Config.
bison -y  -v -p itex2MML_yy -d itex2MML.y
flex -Pitex2MML_yy -olex.yy.c itex2MML.l
conflicts: 750 shift/reduce, 113 reduce/reduce
/usr/bin/gcc-4.2 -Os -w -pipe -march=core2 -c -o lex.yy.o lex.yy.c
/usr/bin/gcc-4.2 -Os -w -pipe -march=core2 -c -o y.tab.o y.tab.c
/usr/bin/g++-4.2 -Os -w -pipe -march=core2 -o itex2MML lex.yy.o y.tab.o itex2MML.cc
==> make install BINDIR=/Users/adamv/homebrew/Cellar/itex2mml/1.4.9/bin
make install BINDIR=/Users/adamv/homebrew/Cellar/itex2mml/1.4.9/bin
-e:1: Use RbConfig instead of obsolete and deprecated Config.
-e:1: Use RbConfig instead of obsolete and deprecated Config.
install -c itex2MML /Users/adamv/homebrew/Cellar/itex2mml/1.4.9/bin
strip /Users/adamv/homebrew/Cellar/itex2mml/1.4.9/bin/itex2MML
==> Finishing up
ln -s ../../../Users/adamv/homebrew/Cellar/itex2mml/1.4.9/bin/itex2MML itex2MML
Error: The linking step did not complete successfully
The formula built, but is not symlinked into /usr/local
You can try again using `brew link itex2mml'
==> Summary
/Users/adamv/homebrew/Cellar/itex2mml/1.4.9: 3 files, 136K, built in 4 seconds
[~/homebrew] (b)⚡
@stepheneb

I'm on 10.6.8 and don't get the linking error:

$ brew install -v itex2mml
==> Downloading http://golem.ph.utexas.edu/~distler/blog/files/itexToMML-1.4.9.tar.gz
Already downloaded: /Users/stephen/Library/Caches/Homebrew/itex2mml-1.4.9.tar.gz
/usr/bin/tar xf /Users/stephen/Library/Caches/Homebrew/itex2mml-1.4.9.tar.gz
==> make
make 
-e:1: Use RbConfig instead of obsolete and deprecated Config.
-e:1: Use RbConfig instead of obsolete and deprecated Config.
bison -y  -v -p itex2MML_yy -d itex2MML.y
flex -Pitex2MML_yy -olex.yy.c itex2MML.l
conflicts: 750 shift/reduce, 113 reduce/reduce
/usr/bin/gcc-4.2 -Os -w -pipe -march=core2 -msse4 -c -o lex.yy.o lex.yy.c
/usr/bin/gcc-4.2 -Os -w -pipe -march=core2 -msse4 -c -o y.tab.o y.tab.c
/usr/bin/g++-4.2 -Os -w -pipe -march=core2 -msse4 -o itex2MML lex.yy.o y.tab.o itex2MML.cc
==> make install prefix=/usr/local/Cellar/itex2mml/1.4.9 BINDIR=/usr/local/Cellar/itex2mml/1.4.9/bin
make install prefix=/usr/local/Cellar/itex2mml/1.4.9 BINDIR=/usr/local/Cellar/itex2mml/1.4.9/bin
-e:1: Use RbConfig instead of obsolete and deprecated Config.
-e:1: Use RbConfig instead of obsolete and deprecated Config.
install -c itex2MML /usr/local/bin
rmdir: /usr/local/Cellar/itex2mml/1.4.9/bin (empty)
==> Finishing up
ln -s ../../Cellar/itex2mml/1.4.9 itex2mml
==> Summary
/usr/local/Cellar/itex2mml/1.4.9: 2 files, 12K, built in 2 seconds

Are you on 10.7.3? Do you get an error running the link command manually?

ln -s ../../../Users/adamv/homebrew/Cellar/itex2mml/1.4.9/bin/itex2MML itex2MML

Is there more info available about what the error was?

@adamv
Owner

Pulled as 6566be7 - sorry about the delay.

@adamv adamv closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 26, 2012
  1. @stepheneb

    itex2MML v1.4.9

    stepheneb authored
This page is out of date. Refresh to see the latest.
Showing with 26 additions and 0 deletions.
  1. +26 −0 Library/Formula/itex2mml.rb
View
26 Library/Formula/itex2mml.rb
@@ -0,0 +1,26 @@
+# From: Jacques Distler <distler@golem.ph.utexas.edu>
+# You can always find the latest version by checking
+# http://golem.ph.utexas.edu/~distler/code/itexToMML/view/head:/itex-src/itex2MML.h
+# The corresponding versioned archive is
+# http://golem.ph.utexas.edu/~distler/blog/files/itexToMML-x.x.x.tar.gz
+
+require 'formula'
+
+class Itex2mml < Formula
+ url 'http://golem.ph.utexas.edu/~distler/blog/files/itexToMML-1.4.9.tar.gz'
+ homepage 'http://golem.ph.utexas.edu/~distler/blog/itex2MML.html'
+ md5 '156a20b8d04e85f07cf4eb992e0756fb'
+
+ def install
+ Dir.chdir("itex-src") do
+ system "make"
+ bin.mkpath
+ system "make", "install", "prefix=#{prefix} BINDIR=#{bin}"
+ end
+ end
+
+ def test
+ system "#{bin}/itex2MML --version"
+ end
+
+end
Something went wrong with that request. Please try again.