This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
Add --force option to brew link
#12898
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -87,6 +87,9 @@ def interactive? | |||
| def one? | |||
| flag? '--1' | |||
| end | |||
| def dryrun? | |||
There was a problem hiding this comment.
Good point, closer to the command-line arg.
`brew link` can now be made to delete any conflicting files using the --force argument. It also has a --dry-run option, similar to git clean -n, which will list any files which would be deleted without touching the filesystem. Closes Homebrew#11811.
Add an ARGV.dry_run? helper method for '--dry-run'/'-n' now that '-n' is being used as a git-style dry-run in two commands.
|
I've longed for something like this for ages. Just used it in anger & it worked nicely, thanks. |
|
Going to commit this tonight if there are no objections! |
|
Apparently "tonight" turned into "a week later"... |
Sharpie
pushed a commit
to Sharpie/homebrew
that referenced
this pull request
Jul 9, 2012
Add an ARGV.dry_run? helper method for '--dry-run'/'-n' now that '-n' is being used as a git-style dry-run in two commands. Closes Homebrew#12898. Signed-off-by: Misty De Meo <mistydemeo@gmail.com>
eproxus
pushed a commit
to eproxus/homebrew
that referenced
this pull request
Jul 18, 2012
Add an ARGV.dry_run? helper method for '--dry-run'/'-n' now that '-n' is being used as a git-style dry-run in two commands. Closes Homebrew#12898. Signed-off-by: Misty De Meo <mistydemeo@gmail.com>
snakeyroc3
pushed a commit
to snakeyroc3/homebrew
that referenced
this pull request
Dec 17, 2012
Add an ARGV.dry_run? helper method for '--dry-run'/'-n' now that '-n' is being used as a git-style dry-run in two commands. Closes Homebrew#12898. Signed-off-by: Misty De Meo <mistydemeo@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: #11811, the first commit here adds a
--forceoption tobrew link. This will cause homebrew to delete any conflicting files in the PREFIX before symlinking, similar to the old, destructivebrew linkbehaviour. It also adds a new--dry-run/-noption, similar togit clean, which lists the files--forcewould delete without making any changes to the filesystem.The second commit adds a new
ARGV.dry_run?helper method, since the option was already being checked for manually in another command, and migrates all usages over to it.