Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

c* llvm #14019

Closed
wants to merge 2 commits into from

4 participants

Brett Koonce Max Howell Adam Vandenberg Jack Nagel
Brett Koonce
Owner

is this the correct method of using llvm?

Max Howell
Owner

It works fine with clang, you just have to make it use clang:

inreplace 'csvfix/Makefile', 'g++', 'c++'
inreplace 'alib/Makefile', 'g++', 'c++'

The way to tell it wasn't using clang was the error output where it is clearly calling g++, which is llvm-g++ since a while now.

Brett Koonce
Owner

i tweaked csv-fix per your suggestion
ccputest doesn't seem to yield to the same treatment, though, would the llvm approach be appropriate there?

Jack Nagel jacknagel commented on the diff
Library/Formula/csv-fix.rb
((11 lines not shown))
def install
+ inreplace 'csvfix/Makefile', 'g++', 'c++'
+ inreplace 'alib/Makefile', 'g++', 'c++'
Jack Nagel Owner

It would probably be more correct to substitute $(CXX) here instead, so that it respects things like --use-llvm, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Jack Nagel jacknagel commented on the diff
Library/Formula/cpputest.rb
@@ -2,8 +2,12 @@
class Cpputest < Formula
homepage 'http://www.cpputest.org/'
- url 'http://downloads.sourceforge.net/project/cpputest/cpputest/v2.3/CppUTest-v2.3.zip'
- md5 '0546bf6d0f1513842cfa781255dcbdda'
+ url 'http://sourceforge.net/projects/cpputest/files/cpputest/v3.1/CppUTest-v3.1.zip'
+ sha1 '8ff6b764a9ca6202582ae0c94545f56b921f39d5'
+
+ fails_with :clang do
+ build 412
Jack Nagel Owner

I think you mean 421, and also a cause should be specified (e.g. the error message that is produced).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Adam Vandenberg
Owner

This patch no longer applies; will accept new single-formula pull requests for review.

Adam Vandenberg adamv closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 7, 2012
  1. Brett Koonce

    CppUTest v3.1

    asparagui authored
  2. Brett Koonce

    csv-fix 1.3

    asparagui authored
This page is out of date. Refresh to see the latest.
Showing with 11 additions and 5 deletions.
  1. +6 −2 Library/Formula/cpputest.rb
  2. +5 −3 Library/Formula/csv-fix.rb
8 Library/Formula/cpputest.rb
View
@@ -2,8 +2,12 @@
class Cpputest < Formula
homepage 'http://www.cpputest.org/'
- url 'http://downloads.sourceforge.net/project/cpputest/cpputest/v2.3/CppUTest-v2.3.zip'
- md5 '0546bf6d0f1513842cfa781255dcbdda'
+ url 'http://sourceforge.net/projects/cpputest/files/cpputest/v3.1/CppUTest-v3.1.zip'
+ sha1 '8ff6b764a9ca6202582ae0c94545f56b921f39d5'
+
+ fails_with :clang do
+ build 412
Jack Nagel Owner

I think you mean 421, and also a cause should be specified (e.g. the error message that is produced).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+ end
def install
system "make"
8 Library/Formula/csv-fix.rb
View
@@ -1,12 +1,14 @@
require 'formula'
class CsvFix < Formula
- url 'http://csvfix.googlecode.com/files/csvfix_src_110a.zip'
homepage 'http://code.google.com/p/csvfix/'
- version '1.1a'
- sha1 'd579c6223a9570e207b9e9b9eccb7f621916e673'
+ url 'https://bitbucket.org/neilb/csvfix/get/6c861665bf41.tar.bz2'
+ version '1.3'
+ sha1 'c69112be21f08d3f424bba0d1ee3be7376b5e7f6'
def install
+ inreplace 'csvfix/Makefile', 'g++', 'c++'
+ inreplace 'alib/Makefile', 'g++', 'c++'
Jack Nagel Owner

It would probably be more correct to substitute $(CXX) here instead, so that it respects things like --use-llvm, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
system "make lin"
bin.install 'csvfix/bin/csvfix'
end
Something went wrong with that request. Please try again.