Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Arcanist #14445

Closed
wants to merge 3 commits into from

4 participants

James R. Adam Vandenberg gnzlbg Mike McQuaid
James R.

Arcanist, facebook's OSS code review tool

Adam Vandenberg

Need to use a tagged download.

Adam Vandenberg

Need to use a tagged download.

Adam Vandenberg
Owner

That's not actually a tag; can we ask the upstream project to add a 1.0.1 git tag?

Adam Vandenberg
Owner

Per official documentation http://www.phabricator.com/docs/phabricator/article/Arcanist_User_Guide.html#installing-arcanist this is a head-only formula; rejecting for inclusion in core because of this (sorry.)

Adam Vandenberg adamv closed this
gnzlbg

@adamv Why are head-only formulas not allowed?

Mike McQuaid
Owner

@gnzlbg Because if upstream pushes a bad commit then it breaks the formula and we have no way of fixing it.

gnzlbg

@mikemcquaid if upstream pushes a bad commit the formula remains correct, only the code/software is broken. That is upstream fault due to the bad commit. People interested in providing a workaround could do something about it (like temporarily checking out a given revision) but I think it is not worth it.

Mike McQuaid
Owner

It's a poor user experience, regardless. That's why we don't support them in core.

gnzlbg

Maybe one could support them in a different repo that one can tap like homebrew-heads or similar.

gnzlbg

@mikemcquaid my bad :D

Victor Robertson vmrob referenced this pull request in Homebrew/homebrew-head-only
Closed

Arcanist, a command-line interface to Phabricator #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 27, 2012
  1. James R.

    arcanist formula

    Hebo authored
  2. James R.

    add caveats

    Hebo authored
Commits on Oct 4, 2012
  1. James R.

    Update Library/Formula/arcanist.rb

    Hebo authored
    upgrade version
This page is out of date. Refresh to see the latest.
Showing with 33 additions and 0 deletions.
  1. +33 −0 Library/Formula/arcanist.rb
33 Library/Formula/arcanist.rb
View
@@ -0,0 +1,33 @@
+require 'formula'
+
+class Arcanist < Formula
+ class Libphutil < Formula
+ url 'https://github.com/facebook/libphutil/zipball/795212bf9d7a87397b8ada3926d11a88efdd556b'
+ sha1 'cd3eca0063e744ce6724fcc68f747090fa4f31f6'
+ version '1.0.1'
+ end
+
+ homepage 'http://phabricator.org'
+ url 'https://github.com/facebook/arcanist/zipball/d0425fc238c3255f1436f311424121255adfab62'
+ version '1.0.1'
+ sha1 '8c7f8be79e2c5cefe13e17feb8cde141e01794f6'
+
+ def install
+ Libphutil.new.brew do
+ (prefix + "libphutil/").install Dir['*']
+ end
+
+ (prefix + "arcanist/").install %w{bin externals resources scripts src}
+ bin.install_symlink prefix + "arcanist/bin/arc"
+ end
+
+ def test
+ system "arc help"
+ end
+
+ def caveats
+ <<-EOS.undent
+ Now check out http://www.phabricator.com/docs/phabricator/article/Arcanist_User_Guide.html#overview
+ EOS
+ end
+end
Something went wrong with that request. Please try again.