Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

povray 3.7.0.RC6 squashed #15576

Closed
wants to merge 1 commit into from

7 participants

@royhodgman

Note: this pull request is a squashed version of the commits in issue #15093.

The previous version of povray (3.6.1) would not compile with recent versions of libpng. This beta version does compile with recent versions of libpng.

Almost all changes to this formula come from studying the povray portfile from MacPorts and reading a bug report about how they solved the same problem.

Note: povray now requires at least Lion to compile.

@royhodgman royhodgman povray 3.7.0.RC6
The previous version of povray (3.6.1) would not compile with recent versions of libpng. This beta version does compile with recent versions of libpng.

Almost all changes to this formula come from studying the [povray portfile][1] from MacPorts and reading [a bug report][2] about how they solved the same problem.

Note: povray now requires at least Lion to compile.

[1]: https://svn.macports.org/repository/macports/trunk/dports/graphics/povray/Portfile "MacPorts POV-Ray portfile"
[2]: https://trac.macports.org/ticket/35949 "MacPorts Ticket 35949"
caa7a4e
@royhodgman royhodgman referenced this pull request
Closed

povray 3.7.0.RC6 #15093

@adamv
Owner

Assuming the original pull request was made from a non-master branch, you can git push -f to update it in place.

@adamv
Owner

Note to other maintainers: I'm OK pulling this as Lion-only, as long as 3.6.1 goes into versions and is mentioned in the caveats/Lion requirement message.

@mistydemeo
Owner

What I'm curious about is...

The previous version of povray (3.6.1) would not compile with recent versions of libpng.

The current version of the formula is using its builtin version of libpng, and shouldn't be trying to link against the system or Homebrew version. Are you still unable to build 3.6.1 on Lion/Mtn Lion?

@royhodgman

@adamv I'll create a pull request for 3.6.1 to be added to versions. Accordingly, I'll update this formula with a message as you suggest. Should I go back to the original pull request and do that there (and squash everything in place), or would you rather have that here?

@royhodgman

@mistydemeo I tried to build 3.6.1 on mtn lion and ran into the same errors reported in the macports bug report listed above. Once I got it to build I didn't investigate about how to make the build work with povray's built in version of libpng.

@bashwell

Is there a workaround at the moment? B/c I'm having the same problems (I think) installing povray on Mountain Lion.

@adamv
Owner

MacPorts packages this version, and it compiles on pretty much all platforms MacPorts supports: https://trac.macports.org/browser/trunk/dports/graphics/povray/Portfile

So, we should clean up this request and merge this.

@adamv adamv was assigned
@boyanpenkov

I came across this when trying to install POVRay this morning; what can do to help close this?

@adamv
Owner

@boyanpenkov brew pull 15576 then brew install povray then tell us if it works or crashes

@adamv adamv referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
@adamv
Owner

Tested OK on a Lion box; will test on Snow Leopard.

@boyanpenkov
@mistydemeo
Owner

Macports doesn't build it on Snow Leopard yet, but this bug report does have a patch which was suggested on the povray forums: https://trac.macports.org/ticket/36940

No idea what the official word is here or whether this is safe, etc. It does build and pass tests for me with it.

@mikemcquaid
Owner

@adamv Want to add?

@adamv
Owner

Didn't compile on Snow Leopard for me

@mikemcquaid
Owner

@adamv Let's either make it Lion-only or close.

@adamv
Owner

I'll make it Lion-only and move 3.6 to versions and suggest that for Snow Leopard users.

@mistydemeo
Owner

@adamv Did you try the patch from the issue I linked? It builds and passes tests on Snow Leopard with that. (Though like I say, I have no idea how "okay" that patch is.)

@adamv adamv closed this pull request from a commit
@royhodgman royhodgman povray 3.7.0.RC6
Closes #15576.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
fba70bb
@adamv adamv closed this in fba70bb
@dholm dholm referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
@cdlm

Still failing on Mountain Lion (10.8.2) now apparently due to boost:

...
c++  -pipe -Wno-multichar -Wno-write-strings -O3 -ffast-math -march=native -D_THREAD_SAFE   -o povray disp_sdl.o disp_text.o ../vfe/libvfe.a ../source/backend/libbackend.a ../source/frontend/libfrontend.a ../source/base/libbase.a ../source/libpovray.a -lIlmImf -L/opt/homebrew/Cellar/openexr/1.7.0/lib -L/opt/homebrew/Cellar/ilmbase/1.0.2/lib -lIlmImf -lz -lImath -lHalf -lIex -lIlmThread   -lIlmThread -ltiff -ljpeg -lpng -lz -lm  -lboost_system-mt -D_THREAD_SAFE
brew: superenv removed: -Wno-multichar -Wno-write-strings -O3 -march=native
Undefined symbols for architecture x86_64:
  "boost::this_thread::interruption_point()", referenced from:
      void boost::condition_variable_any::wait<boost::unique_lock<boost::mutex> >(boost::unique_lock<boost::mutex>&) in libvfe.a(vfesession.o)
...
@royhodgman

It builds fine for me on 10.8.1 and xcode 4.5, so I'm updating both and will try again.

@royhodgman

And now it compiles and renders test scenes fine for me on 10.8.2 and xcode 4.6.

I ran:

brew remove povray
brew remove boost
brew install povray

and didn't see any errors.

@cdlm Which version of boost are you linking against?

@cdlm

boost 1.52.0 (freshly built as a dependency of povray), xcode 4.6… now trying a second build after removing both as you suggest…

(edit, later) …and here's the end of the build log: https://gist.github.com/4700003

@fgeller fgeller referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
@n1k0 n1k0 referenced this pull request from a commit
@royhodgman royhodgman povray 3.7.0.RC6
Closes #15576.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
8083686
@cooljeanius cooljeanius referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
@erbmicha erbmicha referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
@phatblat phatblat referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
@rajeeja rajeeja referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 21, 2012
  1. @royhodgman

    povray 3.7.0.RC6

    royhodgman authored
    The previous version of povray (3.6.1) would not compile with recent versions of libpng. This beta version does compile with recent versions of libpng.
    
    Almost all changes to this formula come from studying the [povray portfile][1] from MacPorts and reading [a bug report][2] about how they solved the same problem.
    
    Note: povray now requires at least Lion to compile.
    
    [1]: https://svn.macports.org/repository/macports/trunk/dports/graphics/povray/Portfile "MacPorts POV-Ray portfile"
    [2]: https://trac.macports.org/ticket/35949 "MacPorts Ticket 35949"
This page is out of date. Refresh to see the latest.
Showing with 50 additions and 17 deletions.
  1. +50 −17 Library/Formula/povray.rb
View
67 Library/Formula/povray.rb
@@ -1,37 +1,70 @@
require 'formula'
+class NeedsLion < Requirement
+ def satisfied?
+ MacOS.version >= :lion
+ end
+ def message
+ "PovRay 3.7.0.RC6 requires Mac OS X 10.7 or newer"
+ end
+ def fatal?
+ true
+ end
+end
+
class Povray < Formula
- url 'http://www.povray.org/ftp/pub/povray/Official/Unix/povray-3.6.1.tar.bz2'
homepage 'http://www.povray.org/'
- sha1 '1fab3ccbdedafbf77e3a66087709bbdf60bc643d'
+ url 'http://www.povray.org/beta/source/povray-3.7.0.RC6.tar.gz'
+ sha256 '374957bdb90fb7be5f36f839b3f04ab0a4340f6e8cf369f658d6592a342803e3'
+ version '3.7.0.RC6'
- depends_on 'libtiff' => :optional
- depends_on 'jpeg' => :optional
+ option 'use-openexr', 'Compile with OpenEXR support.'
+ option 'use-zlib', 'Compile with zlib support.'
- # TODO give this a build number (2326?)
- fails_with :llvm do
- cause "povray fails with 'terminate called after throwing an instance of int'"
- end if MacOS.version == :leopard
+ depends_on NeedsLion.new
+ depends_on 'boost'
+ depends_on 'jpeg'
+ depends_on 'libpng'
+ depends_on 'libtiff'
+ depends_on 'openexr' => :optional if build.include? 'use-openexr'
def patches
- # povray has issues determining libpng version; can't get it to compile
- # against system libpng, but it works with its internal libpng.
- # Look at this again on the next povray version bump!
- {:p0 => "https://trac.macports.org/export/97719/trunk/dports/graphics/povray/files/patch-configure"}
+ {:p0 => [
+ "http://svn.macports.org/repository/macports/trunk/dports/graphics/povray/files/patch-boost-1.50.diff",
+ "http://svn.macports.org/repository/macports/trunk/dports/graphics/povray/files/patch-configure-stat.diff",
+ "http://svn.macports.org/repository/macports/trunk/dports/graphics/povray/files/patch-lseek64.diff",
+ "http://svn.macports.org/repository/macports/trunk/dports/graphics/povray/files/patch-vfe-uint.diff"
+ ]}
+
end
def install
- system "./configure", "--disable-debug", "--disable-dependency-tracking",
- "COMPILED_BY=homebrew",
- "--prefix=#{prefix}",
- "--mandir=#{man}"
+
+ # while this is RC6, the code still says RC5, so update to reflect that
+ inreplace [ 'VERSION', 'configure' ], '3.7.0.RC5', '3.7.0.RC6'
+
+ # include the boost system library to resolve compilation conflicts
+ ENV["LIBS"] = "-lboost_system-mt"
+
+ args = [
+ "COMPILED_BY=homebrew",
+ "--disable-debug",
+ "--disable-dependency-tracking",
+ "--prefix=#{prefix}",
+ "--mandir=#{man}",
+ ]
+
+ args << "--with-openexr=${HOMEBREW_PREFIX}" if build.include? "use-openexr"
+ args << "--with-zlib=${HOMEBREW_PREFIX}" if build.include? "use-zlib"
+
+ system "./configure", *args
system "make install"
end
def test
ohai "Rendering all test scenes; this may take a while"
mktemp do
- system "#{share}/povray-3.6/scripts/allscene.sh", "-o", "."
+ system "#{share}/povray-3.7.0.RC6/scripts/allscene.sh", "-o", "."
end
end
end
Something went wrong with that request. Please try again.