Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

freeDiameter 1.1.5 #15845

Closed
wants to merge 1 commit into from

4 participants

@ghost

diameter aaa protocol server: http://www.freediameter.net/trac/

@adamv
Owner

It has been less than a day, please have patience.

@mikemcquaid
Owner

@humdedum Be polite and patient. We're busy people with jobs who work on Homebrew in our spare time.

@mikemcquaid
Owner

:recommended indicates that a dependency is not required for the formula to function but is recommended for usual functionality. An example would by PNG support in an image viewer; it's something that most users will make use of.

These flags are not currently used as the functionality has not been completed but we try and keep them accurate when possible so we can make use of them in future.

You still don't seem to have learned how to be polite. Homebrew is open-source so it's perfectly possible for you to have found all this out yourself. We have hundreds of other issues to deal with, many of which are more important than this. I'm going to just delete any comments you post that are rude.

@ghost ghost closed this
@mikemcquaid mikemcquaid referenced this pull request
Closed

freeDiameter 1.1.5 #15870

@mikemcquaid mikemcquaid reopened this
@jacknagel
Collaborator

Has the gnutls update been tested against stuff in brew uses gnutls? It already exists in homebrew-versions because I didn't want to test it against all of its dependent formulae.

@jacknagel
Collaborator

See as nothing actually requires version 3.x, I'd rather be conservative and make sure everything works. So basically everything that has a direct or transitive dependency on it (brew uses -r gnutls) should be tested.

@ghost

It has DTLS support, which will most probably be need in freeDiameter in few days.

@ghost

brew install aqbanking bitlbee finch glib-networking gobby gst-plugins-good gwenhywfar ideviceinstaller ifuse inspircd kbtin lftp libimobiledevice libinfinity libpurple libsoup libvirt libxmlsec1 loudmouth mcabber minbif net6 nzbget obby pan pianobar qemu tiger-vnc weechat wireshark
https://raw.github.com/gist/4021546/c29e49314c87f4a948c485ef8feb11382fee2328/stdout

Library/Logs/Homebrew: https://github.com/humdedum/logs

libinfinity, gobby, libpar2 and nzbget required --use-llvm
gobby, libpurple brew failed to link but that does not look like it has anything to do with gnutls. You can see conflicting files in gist above for these two if you search for brew link.
qemu site was offline (tested from mirror: works)
tiger-vnc is only one that is dependent on 2x which I am looking right now if there is workaround.

brew --config
HOMEBREW_VERSION: 0.9.3
HEAD: a1c14684164154be5efeb7669d85888aaabbd192
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CELLAR: /usr/local/Cellar
CPU: dual-core 64-bit penryn
OS X: 10.7.5-i386
Xcode: 4.5.2
CLT: 4.5.0.0.1.1249367152
LLVM-GCC: build 2336
Clang: 4.1 build 421
X11: 2.6.4 => /usr/X11
System Ruby: 1.8.7-358
Perl: /usr/bin/perl
Python: /usr/bin/python
Ruby: /usr/bin/ruby => /System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/bin/ruby

*just edited --config above, I accidentally run it on my mac mini and not on the machine I was testing this.

@jacknagel
Collaborator

Cool, thanks for the diligence on this.

@ghost

I added tiger-vnc gnutls 3x patch. Got qemu tarball from their official github mirror, since their site is still offline (I cannot add it as mirror because they do not provide same compression type on mirror) - it works.

Does github send email everytime I update comment ?

@ghost

Ok this #14456 finally explained me what => :recommended does. That should be put in wiki once it's done.

So I will remove => :recommended as I cannot separate them and then use with_option or however you decide to name it once it's done.

@ghost

freeDiameter formula now uses :postgresql and :mysql.

@2bits

Don't worry about marking things as recommended or optional, especially because neither does anything at the moment. Jack's PR to enable those might land in a month. In the meantime you only need to mark things as => :build or nothing at all. Thanks for working on these.

@ghost

@jacknagel enabling :postgresql and :mysql should not conflict with anything ? to revert it or not ?

@ghost

ping @jacknagel I helped this guy make freeDiameter portable on mac and made a mistake telling him it will be available on homebrew as granted thinking: cool you want new formulas, it would be my first one :-) yay. We put homebrew method in mac os installation instruction. I tried to change everything that you have asked me to change.

@jacknagel
Collaborator

If you do not want it, just tell me so I can go on with my life.

If you need me to make a decision _right now_, then no. If you are willing to be patient and lose the attitude, I'll be more than happy to review this, _when I have time to review it_. Please understand that turnaround time > 3 days is not at all unusual, especially for new formulae as they require more scrutiny.

Unless you can magically add hours to the day or wish to hire me to work on Homebrew full-time, repeatedly pinging me isn't going to increase the amount of time I can spend reviewing contributions.

@2bits

Let's make sure you're clear @humdedum your options while this works its way along. Feel free to ask questions like the one you did about :postgresql and whatnot. Because you directed it at Jack, I didn't answer it, but I can see your motivated. So I can probably help with the details, and one of the admins like Jack can do the final review.

After you're happy with the formula and it's still pending, you can still have your users/friends use it by installing via url:

brew install https://raw.github.com/humdedum/homebrew/master/Library/Formula/freediameter-server.rb

I just wanted to mention that so you don't feel like your work has hit a roadblock. Now let me make some points on how the workflow usually goes around here. Just like GitHub Help's "Bootcamp" explains, people fork mxcl/Homebrew and then create a new branch, perhaps newFreediameterServer, then they make one new thing happen in that branch, in this case the new formula. Then they submit that as a pull request. What you did was different in two respects. You submitted this off master, and you submitted four changes. That complicates things, and may not be acceptable to the admins for gory reasons that are better left unexplained.

Assuming you had four branches and four pull requests submitted, the simpler ones often get pulled first. So some progress gets made. I've had new formulas take weeks and even months for complex ones to be accepted. Once you've made your case and fixed all the issues, it shouldn't take long.

I'll make some points inline in the code, but I can also say that there is no :mysql syntax in Homebrew. The easy way to check things like that is with

brew grep :mysql

Then you can see how that dependency is crafted. You can do the same with postgresql if you use the right case:

brew grep PostgresqlInstalled

where you will see how we craft PGS requirements. Please bear with us if we seem old, as we don't answer things around here in real time like ppl do with SMS or email these days. It's because my Apple II is slow.

@ghost

@2bits I was inquiring if this was ready to be used #15878

@jacknagel
Collaborator

You can use :mysql and :postgresql now, I just pushed my patch.

@ghost

Updated.

@ghost

Would it be OK if I closed this PR and open one from non-master branch ?

@adamv
Owner

Sure

@ghost ghost closed this
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 8, 2012
  1. freeDiameter 1.1.5

    Stefan authored
This page is out of date. Refresh to see the latest.
Showing with 83 additions and 0 deletions.
  1. +83 −0 Library/Formula/freediameter-server.rb
View
83 Library/Formula/freediameter-server.rb
@@ -0,0 +1,83 @@
+require 'formula'
+
+class FreediameterServer < Formula
+ homepage 'http://www.freediameter.net'
+ url 'http://www.freediameter.net/hg/freeDiameter/archive/1.1.5.tar.gz'
+ sha1 'bcbda1683f2d502506478c9916313b25dc73a714'
+
+ option 'with-all-extensions', 'Enable all extensions'
+
+ depends_on 'cmake' => :build
+ depends_on 'gnutls'
+
+ if build.include? 'with-all-extensions'
+ depends_on :postgresql
+ depends_on :mysql
+ depends_on 'swig' => :build
+ end
+
+ depends_on 'libidn'
+
+ def install
+
+ cmake_args = %W[
+ .
+ -DCMAKE_INSTALL_PREFIX=#{prefix}
+ -DDEFAULT_CONF_PATH=#{etc}
+ -DDISABLE_SCTP=ON
+ ]
+
+ cmake_args << '-DALL_EXTENSIONS=ON' if build.include? 'with-all-extensions'
+
+ system 'cmake', *cmake_args
+ system 'make'
+ system 'make install'
+
+ mv 'doc', prefix
+ mv 'contrib', prefix
+
+ unless File.exists?(etc/'freeDiameter.conf')
+ cp prefix/'doc/freediameter.conf.sample', etc/'freeDiameter.conf'
+ end
+
+ end
+
+ def caveats; <<-EOS.undent
+ To configure freeDiameter, edit #{etc}/freeDiameter.conf to taste.
+
+ Sample configuration files can be found in #{prefix}/doc
+
+ For more information about freeDiameter configuration options, read:
+ http://www.freediameter.net/trac/wiki/Configuration
+
+ Other potentially usefull files can be found in #{prefix}/contrib
+
+ To load freeDiameter automatically on startup, install and load the provided launchd
+ item as follows:
+
+ sudo cp #{plist_path} /Library/LaunchDaemons
+ sudo launchctl load -w /Library/LaunchDaemons/#{plist_path.basename}
+ EOS
+ end
+
+ def startup_plist; <<-EOS.undent
+ <?xml version="1.0" encoding="UTF-8"?>
+ <!DOCTYPE plist PUBLIC "-//Apple Computer//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+ <plist version="1.0">
+ <dict>
+ <key>Label</key>
+ <string>#{plist_name}</string>
+ <key>ProgramArguments</key>
+ <array>
+ <string>#{HOMEBREW_PREFIX}/bin/freeDiameterd</string>
+ </array>
+ <key>KeepAlive</key>
+ <dict>
+ <key>NetworkState</key>
+ <true/>
+ </dict>
+ </dict>
+ </plist>
+ EOS
+ end
+end
Something went wrong with that request. Please try again.