Skip to content
This repository

Update percona-server to use mysql data & share directory if no previous percona data directory exists. #15921

Merged
merged 0 commits into from over 1 year ago

2 participants

Stefan Jack Nagel
Stefan

Code for #15901.

Stefan

Updated. mysql_install_db creates "#{var}/#{destination}" and for some reason didn't work as (var/destination).mkpath anyway.

Library/Formula/percona-server.rb
... ...
@@ -113,9 +117,6 @@ def caveats; <<-EOS.undent
113 117
 
114 118
         Note: if this fails, you probably forgot to run the first two steps up above
115 119
 
116  
-    A "/etc/my.cnf" from another install may interfere with a Homebrew-built
117  
-    server starting up correctly.
118  
-
2
Jack Nagel Owner

Reason for removing this?

I copied that from original pull-request, didn't give a specific though to it ? do you want it back ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Library/Formula/percona-server.rb
((5 lines not shown))
88 91
     # Fix up the control script and link into bin
89 92
     inreplace "#{prefix}/support-files/mysql.server" do |s|
90 93
       s.gsub!(/^(PATH=".*)(")/, "\\1:#{HOMEBREW_PREFIX}/bin\\2")
91 94
     end
  95
+
1
Jack Nagel Owner

Please avoid unrelated whitespace changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Stefan

If you agree with this: #16055 I can remove that line here.

Library/Formula/percona-server.rb
((9 lines not shown))
32 37
   def install
33 38
     # Build without compiler or CPU specific optimization flags to facilitate
34 39
     # compilation of gems and other software that queries `mysql-config`.
35 40
     ENV.minimal_optimization
36 41
 
37  
-    # Make sure the var/msql directory exists
38  
-    (var+"percona").mkpath
39  
-
3
Jack Nagel Owner

I'm curious why, as you noted, this doesn't work as (var/destination).mkpath. Presumably it made its way into the mysql family of formulae for a reason.

It works! I must have screwed something when I was testing it. GitHub closed PR when I pushed empty branch with FD. I have added it back.

Oh yes, I remember what was wrong, I was looking for percona folder, which I was deleting, but it would never create percona folder, it only can create mysql directory. Do I need to open new RP ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Stefan humdedum merged commit 66682e5 into from November 14, 2012
Stefan humdedum closed this November 14, 2012
Jack Nagel
Owner

I can't reopen this, so you can just submit a new PR.

Stefan

Should I also remove std_cmake_args as in #16055 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Sorry, commit information is not available for this pull request.

This page is out of date. Refresh to see the latest.

Showing 0 changed files with 0 additions and 0 deletions. Show diff stats Hide diff stats

Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.