Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

drizzle: remove LD/CPPFLAGS #15998

Closed
wants to merge 1 commit into from

2 participants

@ghost

boost149 is keg only.

@ghost

boost149, it does not work yet with latter versions.

@adamv
Owner

I'll try this on Lion when I get a chance.

On Snow Leopard, getting an unrelated:

drizzled/drizzled.cc: In function ‘void drizzled::create_pid_file()’:
drizzled/drizzled.cc:417: error: ‘O_CLOEXEC’ was not declared in this scope
@ghost

SL doesn't support O_CLOEXEC

@adamv
Owner

So should we mark this as no longer supporting Snow Leopard?

@ghost

There is patch: https://bugs.launchpad.net/gearmand/+bug/980114 commen # 6 I can prepare that.

@ghost

Actual patch: https://launchpadlibrarian.net/102708957/fcntl.patch Do you think it is worth patching ?

@jacknagel
Owner

Someone could let them know that on 10.6, FD_CLOEXEC is defined rather than O_CLOEXEC.

@ghost

Brian Aker is the one who started drizzle fork, so If he hasn't seen fit to include it in last 6 months I do not think I can persuade him any more :-).

@ghost

well on closer inspection it is actually bug about Gearman so I might stand some chance.

@adamv
Owner

Probably no one on Snow Leopard is trying to use Drizzle or we would have gotten more bug reports, so I'm OK deprecating SL support on this instead of patching, and pointing people upstream.

@ghost

Updated.

@adamv adamv closed this pull request from a commit
Stefan drizzle: remove LD/CPPFLAGS
Closes #15998.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
8e7ef43
@adamv adamv closed this in 8e7ef43
@manboubird manboubird referenced this pull request from a commit in manboubird/homebrew
Stefan drizzle: remove LD/CPPFLAGS
Closes #15998.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
ec71696
@manboubird manboubird referenced this pull request from a commit in manboubird/homebrew
Stefan drizzle: remove LD/CPPFLAGS
Closes #15998.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
5e447cb
@nilsonholger nilsonholger referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
@snakeyroc3 snakeyroc3 referenced this pull request from a commit in snakeyroc3/homebrew
Stefan drizzle: remove LD/CPPFLAGS
Closes #15998.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
dba32d8
@gwydirsam gwydirsam referenced this pull request from a commit
Stefan drizzle: remove LD/CPPFLAGS
Closes #15998.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
25f0d1e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 18, 2012
  1. drizzle: remove LD/CPPFLAGS

    Stefan authored
This page is out of date. Refresh to see the latest.
Showing with 12 additions and 6 deletions.
  1. +12 −6 Library/Formula/drizzle.rb
View
18 Library/Formula/drizzle.rb
@@ -1,10 +1,22 @@
require 'formula'
+class LionOrNewer < Requirement
+ def satisfied?
+ MacOS.version >= :lion
+ end
+
+ def message
+ "Drizzle requires Mac OS X 10.7 (Lion) or newer."
+ end
+end
+
class Drizzle < Formula
homepage 'http://drizzle.org'
url 'https://launchpad.net/drizzle/7.1/7.1.36/+download/drizzle-7.1.36-stable.tar.gz'
sha1 '6ce317d6a6b0560e75d5bcf44af2e278443cfbfe'
+ depends_on LionOrNewer.new
+
depends_on 'protobuf'
# https://github.com/mxcl/homebrew/issues/14289
@@ -17,12 +29,6 @@ class Drizzle < Formula
depends_on 'readline'
def install
-
- old_boost = Formula.factory('boost149')
-
- ENV.append 'LDFLAGS', "-L#{old_boost.prefix}/lib"
- ENV.append 'CPPFLAGS', "-I#{old_boost.prefix}/include"
-
system "./configure", "--disable-dependency-tracking",
"--prefix=#{prefix}"
system "make install"
Something went wrong with that request. Please try again.