Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Revert share directory change, remove std_cmake_args. #16055

Closed
wants to merge 1 commit into from

2 participants

@gergoerdosi

Share directory change in f7eaa7c caused issues, for example mysql_install_db exited with an error:

FATAL ERROR: Could not find errmsg.sys

The following directories were searched:

/usr/local/opt/percona-server/share/english
/usr/local/opt/percona-server/share/mysql/english

I made the change because I thought Percona Server uses /usr/local/share as share directory, not its own directory under opt. In this case using /percona is not needed.

I also removed std_cmake_args, because for example it adds -DCMAKE_BUILD_TYPE=None which is later overwritten anyway with -DCMAKE_BUILD_TYPE=RelWithDebInfo, so it doesn't make too much sense. Neither mysql nor mariadb uses std_cmake_args.

@jacknagel
Owner

I made the change because I thought Percona Server uses /usr/local/share as share directory, not its own directory under opt. In this case using /percona is not needed.

/usr/local/opt is a separate directory structure. Things still get linked into /usr/local/share as before. I see both the mysql and mariadb formulae specify share/name for this.

@gergoerdosi

I see, haven't known about symlinks. They are indeed wrong, /percona is needed. I'll try to figure out why mysql_install_db gives that error in this case.

@gergoerdosi

Ok, found the cause. This line is in mysql_install_db:

langdir=`find_in_basedir --dir errmsg.sys share/english share/mysql/english`

It looks for the language files in share/english and share/mysql/english, that's why it can't find them in share/percona/english. Shall I make an other pull request which changes "-DINSTALL_MYSQLSHAREDIR=#{share.basename}/percona", to "-DINSTALL_MYSQLSHAREDIR=#{share.basename}/mysql", ?

@ghost Unknown referenced this pull request
Closed

percona-server fixes #16070

@jacknagel
Owner

Addressed by #16070.

@jacknagel jacknagel closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 3 additions and 2 deletions.
  1. +3 −2 Library/Formula/percona-server.rb
View
5 Library/Formula/percona-server.rb
@@ -37,14 +37,15 @@ def install
# Make sure the var/percona directory exists
(var+"percona").mkpath
- args = std_cmake_args + [
+ args = [
".",
+ "-DCMAKE_INSTALL_PREFIX=#{prefix}",
"-DMYSQL_DATADIR=#{var}/percona",
"-DINSTALL_MANDIR=#{man}",
"-DINSTALL_DOCDIR=#{doc}",
"-DINSTALL_INFODIR=#{info}",
# CMake prepends prefix, so use share.basename
- "-DINSTALL_MYSQLSHAREDIR=#{share.basename}/percona",
+ "-DINSTALL_MYSQLSHAREDIR=#{share.basename}",
"-DWITH_SSL=yes",
"-DDEFAULT_CHARSET=utf8",
"-DDEFAULT_COLLATION=utf8_general_ci",
Something went wrong with that request. Please try again.