Skip to content

Loading…

superenv should filter out -isysroot #16576

Closed
wants to merge 1 commit into from

4 participants

@samueljohn

No description provided.

@samueljohn

ping @mxcl. I am not 100% sure.

I had a software which sets the -isysroot to some outdated /Developer/...something dir and then failed.
Superenv sets SDKROOT, sysroot and isystem.

@adamv

ping @mxcl @mistydemeo @mikemcquaid @jacknagel - anyone have thoughts here? I'm still new to superenv.

@mistydemeo

Fltering out isysroot makes sense to me, given the other flags we're controlling.

We do currently set isysroot in several formulae - has this been tested to make sure it doesn't break them?

@samueljohn

@mistydemeo The only formulae that we should test is fontforge as far as I see. The Python formulae also set -isysroot but this is more or less a trick to make the setup.py store some values in order to make pip install ... work with Xcode-only. This trick will continue to work.

Well, disktype.rb is another formula, but it's -isysroot usage looks very outdated to my anyway.

@adamv

disktype is head-only and should probably be redacted

@adamv

Oh hey it has versioned tarballs now.

@samueljohn

@mxcl I know you are busy ..
Nobody else dares to touch superenv related stuff :-)

@adamv

Can I get an example of a package where this fix allows superenv to work?

@samueljohn

I'm afraid, I can't remember which formula it was. Must have been a pull request on some tab, I tried to test and came up with this. I come back, if I remember which one it was...

@mikemcquaid
Homebrew member

@samueljohn if this works with fontforge I'll merge.

@adamv

So what should I do here, pull and try compiling Fontforge?

@samueljohn

I can test it with fontforge (is fontforge currently broken?)

@adamv

Fontforge installed for me on 10.7/4.6. Anything else I should test?

@samueljohn

Besides I cannot remember which software (I think it is one of the still open pull requests in homebrew-science) sets the -isysroot to some /Developer dir and fucks up, I think we really want to control the isysroot ourself. I mean all of superenv is build around that concept. Setting the include sysroot can only break our stuff.

@adamv

@samueljohn please pull this, thanks!

@samueljohn

will do. Thanks for reviews!

@samueljohn samueljohn added a commit that closed this pull request
@samueljohn samueljohn superenv: Filter out -isysroot
Closes #16576.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
ab562b5
@Sharpie Sharpie pushed a commit to Sharpie/homebrew that referenced this pull request
@samueljohn samueljohn superenv: Filter out -isysroot
Closes #16576.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
5e1189d
@nesv nesv added a commit to nesv/homebrew that referenced this pull request
@samueljohn samueljohn superenv: Filter out -isysroot
Closes #16576.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
acf9afb
@rajeeja rajeeja pushed a commit that referenced this pull request
@samueljohn samueljohn superenv: Filter out -isysroot
Closes #16576.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
6f14358
@samueljohn samueljohn deleted the samueljohn:superenv_filter_isysroot branch
@shelhamer shelhamer added a commit that referenced this pull request
@samueljohn samueljohn superenv: Filter out -isysroot
Closes #16576.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
a825423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 11, 2013
  1. @samueljohn
Showing with 3 additions and 0 deletions.
  1. +3 −0 Library/ENV/4.3/cc
View
3 Library/ENV/4.3/cc
@@ -112,6 +112,9 @@ class Cmd
args << arg if arg =~ /^-Wl,/
when '-macosx_version_min', '-dylib_install_name'
args << "-Wl,#{arg},#{whittler.next}"
+ when /^-isysroot/
+ whittler.next
+ # We set the sysroot
when '-dylib'
args << "-Wl,#{arg}"
when /^-I(.+)/
Something went wrong with that request. Please try again.