Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Add brew-run-configure.sh to contributions, attempt number 2 #17939

Closed
wants to merge 1 commit into from

3 participants

@cooljeanius

I screwed up the branch I was originally going to send this from, so instead it's coming from a third branch. Anyway, differences between this and #16248 include:

  • Being from a non-master branch
  • I have now included directories for testing my script in (this was something @adamv was unsure about last time)
  • The script now has more logging and comments, and does its checks better.
System Administrator New branch for my brew-run-configure.sh script because I screwed up m…
…y last one

- add brew-run-configure.sh
- add some directories for testing it in
d971ff3
@adamv
Owner

Maintainers: is this something we want or not?

@mikemcquaid
Owner

Remind me what this does?

@cooljeanius

It's basically an expansion on brew diy to make installing stuff into Homebrew's Cellar easier

@mikemcquaid
Owner

Could/should this be part of brew diy? I don't see a harm in having it in Contributions regardless.

@cooljeanius

well if this were added to brew diy itself, it'd have to be rewritten in Ruby, and I don't know Ruby, so someone else would have to do that

@mikemcquaid
Owner

Being very stupid here but can you explain what this does that diy doesnt? I'm just wondering if we want two similar commands written in different languages.

(An aside: I didn't know Ruby before contributing to Homebrew either. I now have a job writing Ruby.)

@cooljeanius

brew diy just tells you the configure flag to pass to ./configure, this script actually applies that flag for you and runs it.

@mikemcquaid
Owner

Yeh, in that case I think this should be an argument e.g. brew diy --configure.

@adamv adamv commented on the diff
Library/Homebrew/test/configuring/cmake/Demo/.gitignore
@@ -0,0 +1 @@
+#
@adamv Owner
adamv added a note

What are these gitignore files for?

To keep the directories from being empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@adamv
Owner

If another maintainer wants this include, please work towards inclusion; otherwise I recommend it be a small project external to Homebrew itself. I'll close in a couple days unless another maintainer steps in.

@mikemcquaid
Owner

I'm -1 on this as-is.

@adamv
Owner

Passing on this for inclusion in core, but would link it from the wiki: https://github.com/mxcl/homebrew/wiki/External-Commands

@adamv adamv closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 19, 2013
  1. New branch for my brew-run-configure.sh script because I screwed up m…

    System Administrator authored
    …y last one
    
    - add brew-run-configure.sh
    - add some directories for testing it in
Something went wrong with that request. Please try again.