Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

add ucspi-tcp #18342

Closed
wants to merge 1 commit into from

5 participants

David Kendal Sean B. Palmer Adam Vandenberg Jack Nagel ferriswheel
David Kendal
dpk commented

ucspi-tcp is Daniel J. Bernstein's set of command-line tools for building network applications. This commit adds it as a formula for Homebrew, with the popular IPv6 patch from Fefe.

Sean B. Palmer
sbp commented

Can you add an sha1 to the patch?

Adam Vandenberg
Owner

@sbp we don't currently support checksums on patches

Sean B. Palmer
sbp commented

Do you want the commits to be squashed after making the change requested above?

David Kendal
dpk commented

@adamv Done, thanks to @sbp!

Jack Nagel
Owner

Squash to a single commit, please

Jack Nagel
Owner
Error: Will not overwrite /private/tmp/ucspi-tcp-okDm/ucspi-tcp-0.88/conf-home

need to remove the file before .writeing it.

==> Cleaning
Warning: A top-level "man" directory was found.
Homebrew requires that man pages live under share.
This can often be fixed by passing "--mandir=#{man}" to configure.

man pages need to go under share

ferriswheel

hello,

when will this brew be available?

Adam Vandenberg
Owner

Jack's comments need to be addressed.

Adam Vandenberg
Owner

How did this even install for you with the write error?

Adam Vandenberg
Owner

conf-cc and conf-ld hard-code gcc; ld uses obsolete options.

David Kendal

With the man page problem and the build failure (which I blame entirely on @sbp), I decided to also make an alteration that would make the IPv6 patch optional. I still haven't got round to that. On it now.

David Kendal

Hmm, I don't see how to find the compiler options that conf-cc and conf-ld should use from the Homebrew environment. Is there a variable this is kept in?

Adam Vandenberg
Owner

ENV.cc and ENV.cflags, etc.; check out ENV.rb.

Adam Vandenberg
Owner

Getting:

Error: Will not overwrite /private/tmp/ucspi-tcp-LULf/ucspi-tcp-0.88/conf-home

Adam Vandenberg
Owner

Weirdly I'm not getting the Warning: A top-level "man" directory was found. warning even though a top level man is being installed. Wonder if we broke this check.

Adam Vandenberg
Owner

Oh, this audit is only triggered now for ARGV.homebrew_developer.

I must have been asleep when homebrew_developer happened.

Adam Vandenberg adamv closed this pull request from a commit
David Kendal dpk ucspi-tcp 0.88
Closes #18342.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
a02008e
Adam Vandenberg adamv closed this in a02008e
Adam Vandenberg
Owner

Updated and pulled, thanks for the submission!

Adam Compton handyman5 referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Evan Shelhamer shelhamer referenced this pull request from a commit
David Kendal dpk ucspi-tcp 0.88
Closes #18342.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
ae7ba67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 11, 2013
  1. David Kendal

    add ucspi-tcp

    dpk authored
This page is out of date. Refresh to see the latest.
Showing with 22 additions and 0 deletions.
  1. +22 −0 Library/Formula/ucspi-tcp.rb
22 Library/Formula/ucspi-tcp.rb
View
@@ -0,0 +1,22 @@
+require 'formula'
+
+class UcspiTcp < Formula
+ homepage 'http://cr.yp.to/ucspi-tcp.html'
+ url 'http://cr.yp.to/ucspi-tcp/ucspi-tcp-0.88.tar.gz'
+ sha1 '793b4189795b563085602c030dd8aa0d206ddc0e'
+
+ def patches
+ "http://www.fefe.de/ucspi/ucspi-tcp-0.88-ipv6.diff19.bz2"
+ end
+
+ def install
+ (buildpath/'conf-home').write prefix
+
+ system "make"
+ system "make setup check"
+ end
+
+ def test
+ system "tcpserver"
+ end
+end
Something went wrong with that request. Please try again.