Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

New formula: libvigra #18536

Closed
wants to merge 1 commit into from

4 participants

@apstrand

VIGRA stands for "Vision with Generic Algorithms".

@royhodgman royhodgman referenced this pull request
Closed

adding vigra #18549

@royhodgman

@apstrand I just made a pull request for the same library before I saw that you'd submitted this.

Anyway, I had it build it libjpeg support, can you add that to your formula? Thanks.

@apstrand

I added "jpeg" instead as a dependency, is "libjpg" preferred?

Library/Formula/libvigra.rb
@@ -0,0 +1,20 @@
+require 'formula'
+
+class Libvigra < Formula
+ homepage 'http://hci.iwr.uni-heidelberg.de/vigra/'
+ url 'http://hci.iwr.uni-heidelberg.de/vigra/vigra-1.9.0-src.tar.gz'
+ sha1 '6e4981f4ce75932ec62df6523f577c327f885ba0'
+
+ depends_on 'cmake' => :build
+ depends_on 'jpeg'
+ depends_on 'libpng'
@jacknagel Owner

Use :libpng here, we give libpng special treatment on older OS X that comes with X11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@royhodgman

my mistake again, jpeg is fine

@apstrand

no problem. I was about to do enblend/enfuse as well but now I don't have to, good ;)

@samueljohn

MacPorts (has the outdated 1.8) and depends_on 'fftw-3' and 'openexr'. Are they optional or no longer needed?

Also: what about the python bindings? I am willing to work on these if you don't care, @apstrand. Just let me know.
Perhaps I do the python bindings after this has pulled in the improved python support landed.

If I read VIGRA, my inner spam reporter jumps on.

@samueljohn

Also I am not sold on the name 'libvigra' because they call themself just 'vigra'.

@samueljohn

http://hci.iwr.uni-heidelberg.de/vigra/doc/vigra/Installation.html

-DWITH_VIGRANUMPY=1
build VIGRA Python bindings (default: 1). Pass -DWITH_VIGRANUMPY=0 to suppress vigranumpy.

Disable numpy bindings until we got it right?
Makes me think if I should add my numpy formula to homebrew-science...

@royhodgman

I would also support having openexr as an option.

@apstrand

Ok, I changed the name to 'vigra' and added fftw and openexr as dependencies.
@samueljohn if you want to do numpy bindings please go ahead.

@samueljohn

will do the bindings later (waiting for python_next first as it will simplify stuff).
thanks for rework...

Library/Formula/vigra.rb
@@ -0,0 +1,25 @@
+require 'formula'
+
+class Vigra < Formula
+ homepage 'http://hci.iwr.uni-heidelberg.de/vigra/'
+ url 'http://hci.iwr.uni-heidelberg.de/vigra/vigra-1.9.0-src.tar.gz'
+ sha1 '6e4981f4ce75932ec62df6523f577c327f885ba0'
+
+ depends_on 'cmake' => :build
+ depends_on 'jpeg'
+ depends_on :libpng
+ depends_on 'libtiff'
+ depends_on 'hdf5'
+ depends_on 'fftw' => :optional

I guess most users would just want fftw as the default. Perhaps :recommended instead of optional?
For openexr, I am fine with optional since I don't even know it :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Peter Strand New formula: vigra 1.9.0
VIGRA stands for "Vision with Generic Algorithms".
5f6227c
@samueljohn

Testing this again.

But I think we should perhaps add this to homebrew-science instead (which I can do, so you don't have to make another PR)

@royhodgman

How will moving it to homebrew-science affect packages which cite it as a dependency, such as enblend?

@samueljohn

I am fine with depending on formulae in official Homebrew taps like depends_on 'homebrew/science/vigra'.
Don't know where the other maintainer stand. We try to keep the cross-dependencies down but it is illusory to perfectly keep things separate.

@royhodgman

Sure sure. Would a user who has not previously tapped homebrew-science need to do so before depends_on 'homebrew/science/vigra' would work correctly? If not, then I have no opinion about where vigra ends up.

@samueljohn
@royhodgman

Cool. What else needs to be done to get this added?

@samueljohn

I'd love to pull it into homebrew-science. If I copy the code, you won't get reputation as the "author", so perhaps commit the current state of this formula to homebrew-science? Ping me, I'll pull it in.
I guess there is no executable, we could call in a do test block, or is there?

@samueljohn

If you ping me over at homebrew-science, I'll pull quickly as this has been reviewed now.

@royhodgman

It was @apstrand who did all the work for this one, so he should get the credit.

@samueljohn

of course. By "you" I meant the pull request opener ... lucky me I did not add an explicit @mention so now I can get out of this (because indeed, I mixed you up). In related news: Set an avatar for github :-)

@samueljohn samueljohn was assigned
@apstrand

Ok, I sent it to homebrew-science now.

@apstrand apstrand referenced this pull request in Homebrew/homebrew-science
Closed

New formula: vigra 1.9.0 #119

@samueljohn

Thanks.

@samueljohn samueljohn closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 18, 2013
  1. New formula: vigra 1.9.0

    Peter Strand authored
    VIGRA stands for "Vision with Generic Algorithms".
This page is out of date. Refresh to see the latest.
Showing with 25 additions and 0 deletions.
  1. +25 −0 Library/Formula/vigra.rb
View
25 Library/Formula/vigra.rb
@@ -0,0 +1,25 @@
+require 'formula'
+
+class Vigra < Formula
+ homepage 'http://hci.iwr.uni-heidelberg.de/vigra/'
+ url 'http://hci.iwr.uni-heidelberg.de/vigra/vigra-1.9.0-src.tar.gz'
+ sha1 '6e4981f4ce75932ec62df6523f577c327f885ba0'
+
+ depends_on 'cmake' => :build
+ depends_on 'jpeg'
+ depends_on :libpng
+ depends_on 'libtiff'
+ depends_on 'hdf5'
+ depends_on 'fftw' => :recommended
+ depends_on 'openexr' => :optional
+
+
+ def install
+ cmake_args = std_cmake_args
+ cmake_args << '-DWITH_OPENEXR=1' if build.with? 'openexr'
+ mkdir 'build' do
+ system "cmake", "..", *cmake_args
+ system "make install"
+ end
+ end
+end
Something went wrong with that request. Please try again.