Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Add formula for gupnp-tools and subsequent dependencies #25113

Closed
wants to merge 5 commits into from

4 participants

@adammw

Adds formulas for:

  • gupnp-av 0.12.4
  • gupnp-tools 0.8.8
  • gnome-icon-theme 3.10.0
  • icon-naming-utils 0.8.90

Updates:

  • gupnp to version 0.20.8
@adamv
Owner

Please add formula one at a time, with no merge commits.

@adamv
Owner
Error Message

failed: brew audit gupnp-tools
Stacktrace

        Error: 1 problems in 1 formulae
gupnp-tools:
 * Trailing whitespace was found
@adammw

@adamv commits updated as per comments

@adamv
Owner

@BrewTestBot test this please

@adamv adamv commented on the diff
Library/Formula/gupnp.rb
@@ -2,8 +2,8 @@
class Gupnp < Formula
homepage 'https://wiki.gnome.org/GUPnP/'
- url 'http://ftp.gnome.org/pub/GNOME/sources/gupnp/0.20/gupnp-0.20.3.tar.xz'
@adamv Owner
adamv added a note

This should have been submitted as a separate pull request. Does this new version work with upnp-router-control?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@adamv adamv commented on the diff
Library/Formula/gupnp-tools.rb
((9 lines not shown))
+ depends_on 'xz' => :build
+ depends_on 'pkg-config' => :build
+ depends_on 'intltool' => :build
+ depends_on 'gettext'
+ depends_on 'gupnp'
+ depends_on 'gupnp-av'
+ depends_on 'gtk+3'
+ depends_on 'gnome-icon-theme'
+ depends_on 'ossp-uuid'
+
+ def install
+ system "./configure", "--disable-debug", "--disable-dependency-tracking",
+ "--prefix=#{prefix}"
+ system "make", "install"
+ end
+end
@adamv Owner
adamv added a note

Need a hard newline at the end of the file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@adamv
Owner

Trying going to gupnp 0.20.10 and upnp-router-control didn't configure

@adamv
Owner

@Homebrew/owners any opinion on the upnp-router-control situation here?

@mikemcquaid
Owner

@adamv If it's a core formula I guess we need to redact or fix before merging.

@cosmo0920

Currently, gnome-icon-theme 3.12.0 has been released.
It should update gnome-icon-theme Formula 3.12.0 from 3.10.0?

@adamv
Owner

I'm working on updating these.

@adamv
Owner

Debian has a patch for upnp-router-control, so merging these is unblocked.

@adamv
Owner

I've updated the versions here, and trying to run gupnp-av-cp fails with missing icons:

$ gupnp-av-cp 
Dynamic session lookup supported but failed: launchd did not provide a socket path, verify that org.freedesktop.dbus-session.plist is loaded!

(gupnp-av-cp:30268): Gtk-WARNING **: Could not find the icon 'network-workgroup'. The 'hicolor' theme
was not found either, perhaps you need to install it.
You can get a copy from:
    http://icon-theme.freedesktop.org/releases

** (gupnp-av-cp:30268): WARNING **: Failed to load icon network-workgroup: Icon 'network-workgroup' not present in theme

** (gupnp-av-cp:30268): WARNING **: Failed to load icon gtk-network: Icon 'gtk-network' not present in theme
**
ERROR:icons.c:317:init_icons: assertion failed: (icons[i] != NULL)
Abort trap: 6
@adamv
Owner

Adding a dep on hicolor-icon-theme doesn't fix this, though possibly the icon cache isn't rebuilt correctly.

@adamv
Owner

Presumably this software ran correctly on your machine at the time of the pull request?

@adamv
Owner

Wondering if for gnome-icon-theme we need to update the cache for both gtk+2 and gtk+3. Alternately, we can make it gtk+3 only. The "missing" icons are clearly present in the theme.

@adamv
Owner

Using gtk+3 for gnome-icon-theme didn't fix gupnp-av-cp for me. I'm going to take the updates I have, but not pull gupnp-av or gupnp-tools. These will need an updated pull request that runs correctly for further consideration.

@adamv
Owner

Icons are loading now, mostly likely due to Jack's glib fix this afternoon.

@adamv
Owner

Pulled updated versions of these; sorry for the delay.

@adamv adamv closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 12, 2013
  1. @adammw

    icon-naming-utils 0.8.90

    adammw authored
  2. @adammw

    gnome-icon-theme 3.10.0

    adammw authored
  3. @adammw

    gupnp 0.20.8

    adammw authored
  4. @adammw

    gupnp-av 0.12.4

    adammw authored
  5. @adammw

    gupnp-tools 0.8.8

    adammw authored
This page is out of date. Refresh to see the latest.
View
20 Library/Formula/gnome-icon-theme.rb
@@ -0,0 +1,20 @@
+require 'formula'
+
+class GnomeIconTheme < Formula
+ homepage 'https://developer.gnome.org'
+ url 'http://ftp.gnome.org/pub/GNOME/sources/gnome-icon-theme/3.10/gnome-icon-theme-3.10.0.tar.xz'
+ sha256 'c65472b5846c67b97fe75200c5180faccd1347a04caa8390fc0ad23de75b36f6'
+
+ depends_on 'xz' => :build
+ depends_on 'pkg-config' => :build
+ depends_on 'intltool' => :build
+ depends_on 'gettext'
+ depends_on 'gtk+' # we require gtk-update-icon-cache
+ depends_on 'icon-naming-utils'
+
+ def install
+ system "./configure", "--disable-debug", "--disable-dependency-tracking",
+ "--prefix=#{prefix}"
+ system "make", "install"
+ end
+end
View
19 Library/Formula/gupnp-av.rb
@@ -0,0 +1,19 @@
+require 'formula'
+
+class GupnpAv < Formula
+ homepage 'https://wiki.gnome.org/GUPnP/'
+ url 'http://ftp.gnome.org/pub/GNOME/sources/gupnp-av/0.12/gupnp-av-0.12.4.tar.xz'
+ sha256 '548a9cef8ab3007734e20a4ce284c422ae299b7e024a4824299f6ae7e3dd7a5b'
+
+ depends_on 'xz' => :build
+ depends_on 'pkg-config' => :build
+ depends_on 'intltool' => :build
+ depends_on 'gettext'
+ depends_on 'gupnp'
+
+ def install
+ system "./configure", "--disable-debug", "--disable-dependency-tracking",
+ "--prefix=#{prefix}"
+ system "make", "install"
+ end
+end
View
24 Library/Formula/gupnp-tools.rb
@@ -0,0 +1,24 @@
+require 'formula'
+
+class GupnpTools < Formula
+ homepage 'https://wiki.gnome.org/GUPnP/'
+ url 'http://ftp.gnome.org/pub/GNOME/sources/gupnp-tools/0.8/gupnp-tools-0.8.8.tar.xz'
+ sha256 '32ae89bc8d2b2777ca127d91509086fa7285a9211ff3ad1c2e68d17a137c0d98'
+
+ depends_on :x11
+ depends_on 'xz' => :build
+ depends_on 'pkg-config' => :build
+ depends_on 'intltool' => :build
+ depends_on 'gettext'
+ depends_on 'gupnp'
+ depends_on 'gupnp-av'
+ depends_on 'gtk+3'
+ depends_on 'gnome-icon-theme'
+ depends_on 'ossp-uuid'
+
+ def install
+ system "./configure", "--disable-debug", "--disable-dependency-tracking",
+ "--prefix=#{prefix}"
+ system "make", "install"
+ end
+end
@adamv Owner
adamv added a note

Need a hard newline at the end of the file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
View
4 Library/Formula/gupnp.rb
@@ -2,8 +2,8 @@
class Gupnp < Formula
homepage 'https://wiki.gnome.org/GUPnP/'
- url 'http://ftp.gnome.org/pub/GNOME/sources/gupnp/0.20/gupnp-0.20.3.tar.xz'
@adamv Owner
adamv added a note

This should have been submitted as a separate pull request. Does this new version work with upnp-router-control?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
- sha256 'ed7db7506506434d0fd272e3866d7ae985af5b9d7e9e5e120f8581ade90869f0'
+ url 'http://ftp.gnome.org/pub/GNOME/sources/gupnp/0.20/gupnp-0.20.8.tar.xz'
+ sha256 'f70da127e0d35a7b8aecaf6f58b740bbb56836451be33d7aeb7979a5c131eac8'
depends_on 'xz' => :build
depends_on 'pkg-config' => :build
View
15 Library/Formula/icon-naming-utils.rb
@@ -0,0 +1,15 @@
+require 'formula'
+
+class IconNamingUtils < Formula
+ homepage 'http://tango.freedesktop.org/Tango_Icon_Library'
+ url 'http://tango.freedesktop.org/releases/icon-naming-utils-0.8.90.tar.gz'
+ sha1 'a195e635fd663f0697a2a047f0c9134876900cf1'
+
+ depends_on 'pkg-config' => :build
+
+ def install
+ system "./configure", "--disable-debug", "--disable-dependency-tracking",
+ "--prefix=#{prefix}"
+ system "make", "install"
+ end
+end
Something went wrong with that request. Please try again.