Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Add mcrypt formula #25551

Closed
wants to merge 6 commits into from
Closed

Add mcrypt formula #25551

wants to merge 6 commits into from

Conversation

jamel
Copy link
Contributor

@jamel jamel commented Dec 30, 2013

Current mcrypt formula actually delivers mcrypt library but not mcrypt / mdecrypt tools.
This pull request fixes that.

@MikeMcQuaid
Copy link
Member

Could we make the existing mcrypt formula install mcrypt and the tools?

@jamel
Copy link
Contributor Author

jamel commented Dec 30, 2013

Where I can read (or see examples) about several resources installation from one formula?

@MikeMcQuaid
Copy link
Member

grep for resource in the Formula directory.

adamv
adamv reviewed Dec 30, 2013
View reviewed changes
Library/Formula/mcrypt.rb

option :universal

def patches
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this patch been sent upstream?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. It seems that it's only clang issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still needs to go upstream.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link the upstream submission here, ta.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jacknagel jacknagel mentioned this pull request Feb 11, 2014
Closed
@ghost
Copy link

ghost commented Feb 11, 2014

This still needs to go upstream.

@jamel
Copy link
Contributor Author

jamel commented Feb 13, 2014

I just updated the patch and sent it to mcrypt project.
https://sourceforge.net/p/mcrypt/patches/14/

@adamv
Copy link
Contributor

adamv commented Mar 10, 2014

Please add that link as a comment in the formula, and rebase this on master if needed.

@jamel
Copy link
Contributor Author

jamel commented Mar 10, 2014

Link was added

@gotoAndBliss
Copy link

Did this get pushed yet? I did

brew install mcrypt

And when trying to use it in my C library, I get

dyld: lazy symbol binding failed: Symbol not found: _mcrypt_module_open
  Referenced from: /Users/mycomputer/Sites/aes/lib/aes/aes.bundle
  Expected in: flat namespace

Meaning the mcrypt tools are still not included ( Or so I believe.. )

@jamel
Copy link
Contributor Author

jamel commented Apr 9, 2014

@MikeMcQuaid
Is there any reasons to not merge this PR? As I know the last merged build was failed because brew doctor fails on build host.

@MikeMcQuaid
Copy link
Member

@BrewTestBot test this please

MikeMcQuaid
MikeMcQuaid reviewed Apr 9, 2014
View reviewed changes
Library/Formula/mcrypt.rb
url 'https://downloads.sourceforge.net/project/mcrypt/MCrypt/2.6.8/mcrypt-2.6.8.tar.gz'
sha1 '8ae0e866714fbbb96a0a6fa9f099089dc93f1d86'

depends_on 'mhash'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use double-quotes on all new/changed lines and we're good to go.

@Homebrew Homebrew locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
new formula
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jamel @MikeMcQuaid @adamv @gotoAndBliss