Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

New formula for rssh. #27028

Closed
wants to merge 1 commit into from

4 participants

@arminsch

rssh is a restrictes shell that only allows scp and sftp. It compiles and installs almost out of the box (just renamed a conflicting variable name.

Library/Formula/rssh.rb
((4 lines not shown))
+ homepage "http://www.pizzashack.org/rssh"
+ url "http://downloads.sourceforge.net/project/rssh/rssh/2.3.4/rssh-2.3.4.tar.gz"
+ sha1 "e13ae1fdce4b0c89ef70f4695689139c8409e2e8"
+
+ def install
+ system "./configure", "--disable-debug",
+ "--disable-dependency-tracking",
+ "--prefix=#{prefix}",
+ "--mandir=#{man}"
+ system "make"
+ system "make", "install"
+ end
+
+ def patches
+ # Fix for compilation error with clang (global variable log is already defined)
+ DATA
@mikemcquaid Owner

Please submit this upstream and link the submission in the comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Library/Formula/rssh.rb
((7 lines not shown))
+
+ def install
+ system "./configure", "--disable-debug",
+ "--disable-dependency-tracking",
+ "--prefix=#{prefix}",
+ "--mandir=#{man}"
+ system "make"
+ system "make", "install"
+ end
+
+ def patches
+ # Fix for compilation error with clang (global variable log is already defined)
+ DATA
+ end
+ test do
+ system "#{bin}/rssh", "-v"
@mikemcquaid Owner

Can this test be modified to do something more substantial then e.g. --version or --help? See cmake.rb for an example of a formula with a good test. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Library/Formula/rssh.rb
((2 lines not shown))
+
+class Rssh < Formula
+ homepage "http://www.pizzashack.org/rssh"
+ url "http://downloads.sourceforge.net/project/rssh/rssh/2.3.4/rssh-2.3.4.tar.gz"
+ sha1 "e13ae1fdce4b0c89ef70f4695689139c8409e2e8"
+
+ def install
+ system "./configure", "--disable-debug",
+ "--disable-dependency-tracking",
+ "--prefix=#{prefix}",
+ "--mandir=#{man}"
+ system "make"
+ system "make", "install"
+ end
+
+ def patches
@adamv Owner
adamv added a note

By convention we put def patches above def install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@adamv
Owner

One more nit-pick and this looks OK now

@mikemcquaid mikemcquaid commented on the diff
Library/Formula/rssh.rb
@@ -0,0 +1,27 @@
+require "formula"
+
+class Rssh < Formula
+ homepage "http://www.pizzashack.org/rssh"
+ url "https://downloads.sourceforge.net/project/rssh/rssh/2.3.4/rssh-2.3.4.tar.gz"
+ sha1 "e13ae1fdce4b0c89ef70f4695689139c8409e2e8"
+
+ def patches
+ "https://gist.githubusercontent.com/arminsch/9230011/raw/f0c5ed95bbba0be28ce2b5f0d1080de84ec317ab/rsshconf-log-rename.diff"
@mikemcquaid Owner

Has this been submitted upstream? Please do so and link the submission here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@adamv
Owner

@arminsch has the patch been submitted upstream?

Armin Schoisswohl New formula for rssh. 3db55d9
@arminsch
@adamv
Owner

"Upstream" refers to the original project. So it means reading http://www.pizzashack.org/rssh and figuring out where they want bugs and patches reported to.

@arminsch

The patch has now been submitted upstream to pizzashack (http://sourceforge.net/p/rssh/mailman/message/32251335/). As the project is not actively developed any more (only maintenance releases) I'm not sure if and when the patch will be incorporated.

armin

@adamv adamv self-assigned this
@adamv adamv closed this pull request from a commit
Armin Schoisswohl rssh 2.3.4
Closes #27028.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
f860331
@adamv adamv closed this in f860331
@arminsch arminsch deleted the branch
@arminsch arminsch restored the branch
@jayzes jayzes referenced this pull request from a commit
Armin Schoisswohl rssh 2.3.4
Closes #27028.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
c8246bf
@futoase futoase referenced this pull request from a commit
Armin Schoisswohl rssh 2.3.4
Closes #27028.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
a259d4d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 10, 2014
  1. New formula for rssh.

    Armin Schoisswohl authored
This page is out of date. Refresh to see the latest.
Showing with 27 additions and 0 deletions.
  1. +27 −0 Library/Formula/rssh.rb
View
27 Library/Formula/rssh.rb
@@ -0,0 +1,27 @@
+require "formula"
+
+class Rssh < Formula
+ homepage "http://www.pizzashack.org/rssh"
+ url "https://downloads.sourceforge.net/project/rssh/rssh/2.3.4/rssh-2.3.4.tar.gz"
+ sha1 "e13ae1fdce4b0c89ef70f4695689139c8409e2e8"
+
+ def patches
+ "https://gist.githubusercontent.com/arminsch/9230011/raw/f0c5ed95bbba0be28ce2b5f0d1080de84ec317ab/rsshconf-log-rename.diff"
@mikemcquaid Owner

Has this been submitted upstream? Please do so and link the submission here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+ end
+
+ def install
+ system "./configure", "--disable-debug",
+ "--disable-dependency-tracking",
+ "--prefix=#{prefix}",
+ "--mandir=#{man}"
+ system "make"
+ system "make", "install"
+ end
+
+ test do
+ # test to check if everything is linked correctly
+ system "#{bin}/rssh", "-v"
+ # the following test checks if rssh, if invoked without commands and options, fails
+ system "sh", "-c", "! #{bin}/rssh"
+ end
+end
Something went wrong with that request. Please try again.