Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Added ability to build linklint version 2.4.beta with --devel option. #31079

Closed
wants to merge 2 commits into from

4 participants

@keithws

Allow people to build the beta with HTTPS support with the --devel option.

@adamv
Owner

Failing to build:

Error Message

failed: brew install --devel --verbose linklint
Stacktrace

        Error: No such file or directory - READ_ME.txt or README
.beta.tar.gz
Already downloaded: /Library/Caches/Homebrew/linklint-2.4.beta.tar.gz
==> Verifying linklint-2.4.beta.tar.gz checksum
tar xf /Library/Caches/Homebrew/linklint-2.4.beta.tar.gz
@keithws

Sorry about the lazy commit. I cleaned up and audited this formula.

keithws added some commits
@keithws keithws Added ability to build linklint version 2.4.beta with --devel option. 1f3dc16
@keithws keithws The readme file is already named README in the development build so i…
…t does not need to be renamed. Install the README file in shared docs. Add test and patch to fix version reported from the beta.
d529abe
@keithws

Also forgot to rebase... where is my mind? Should be fixed now.

@mikemcquaid mikemcquaid commented on the diff
Library/Formula/linklint.rb
((16 lines not shown))
bin.install "linklint-#{version}" => "linklint"
end
+
+ test do
+ system "#{bin}/linklint", "-version"
@mikemcquaid Owner

Can this test be modified to do something more substantial then e.g. --version or --help? See cmake.rb for an example of a formula with a good test. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@mikemcquaid mikemcquaid commented on the diff
Library/Formula/linklint.rb
@@ -5,8 +5,36 @@ class Linklint < Formula
url 'http://linklint.org/download/linklint-2.3.5.tar.gz'
sha1 'd2dd384054b39a09c17b69e617f7393e44e98376'
+ devel do
+ url 'http://linklint.org/download/linklint-2.4.beta.tar.gz'
+ sha1 'a159d19b700db52e8a9e2d89a0a8984eb627bf17'
+
+ # original author did not update the version reported with the beta
+ patch :DATA
@mikemcquaid Owner

Has this patch been submitted upstream?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@jacknagel
Collaborator

Feedback needs to be addressed.

@jacknagel
Collaborator

Closing due to no response.

@jacknagel jacknagel closed this
@keithws

No, this patch has not been submitted upstream. The original author's website has not been updated since August 13, 2001. I think it is safe to assume the upstream project has been abandoned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 24, 2014
  1. @keithws
  2. @keithws

    The readme file is already named README in the development build so i…

    keithws authored
    …t does not need to be renamed. Install the README file in shared docs. Add test and patch to fix version reported from the beta.
This page is out of date. Refresh to see the latest.
Showing with 29 additions and 1 deletion.
  1. +29 −1 Library/Formula/linklint.rb
View
30 Library/Formula/linklint.rb
@@ -5,8 +5,36 @@ class Linklint < Formula
url 'http://linklint.org/download/linklint-2.3.5.tar.gz'
sha1 'd2dd384054b39a09c17b69e617f7393e44e98376'
+ devel do
+ url 'http://linklint.org/download/linklint-2.4.beta.tar.gz'
+ sha1 'a159d19b700db52e8a9e2d89a0a8984eb627bf17'
+
+ # original author did not update the version reported with the beta
+ patch :DATA
@mikemcquaid Owner

Has this patch been submitted upstream?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+ end
+
def install
- mv 'READ_ME.txt', 'README'
+ mv 'READ_ME.txt', 'README' unless build.devel?
+ (share+'doc/linklint').install "README"
bin.install "linklint-#{version}" => "linklint"
end
+
+ test do
+ system "#{bin}/linklint", "-version"
@mikemcquaid Owner

Can this test be modified to do something more substantial then e.g. --version or --help? See cmake.rb for an example of a formula with a good test. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+ end
end
+
+__END__
+diff --git a/linklint-2.4.beta b/linklint-2.4.beta
+index cf3f9a8..0f30eee 100755
+--- a/linklint-2.4.beta
++++ b/linklint-2.4.beta
+@@ -54,7 +54,7 @@
+ #
+ #========================================================================
+
+-$version = "2.3.1";
++$version = "2.4.beta";
+ $date = "June 21, 2001";
+ $prog = "linklint";
+
Something went wrong with that request. Please try again.