implements formula search fallback #33648
Conversation
|
Thinking on it harder, the message given by the search fallback is a little verbose now. A better one might be with the Thoughts? I feel the maintainers should make this kind of message-design decision, not me. |
|
How long does it take to search the formulae? If it's nearly instant it's probably worth keeping the headings as-is but putting it above the tap output (which will take longer). |
|
It's near-instant on my machine. So, output should look like this? Searching formulae...
relevant-formula
Searching taps...
tapper/relevant-tapAnd if there are, for instance, no taps, leave the headings in place: If I make this change, would you prefer the commits squashed? I know they should be squashed for formulae, but the guide doesn't say for other features. |
|
Output looks good and yup to squashing. thanks! |
mambocab
force-pushed
the
search-fallback
branch
from
c0bc0fc
to
0408129
Compare
|
Done. The output for @MikeMcQuaid: thanks for all the feedback and shepherding! |
|
@Homebrew/owners Any objections to this going in? |
|
Not part of Homebrew/owners, but this is absolutely great. Major kudos on this, very clean and very handy. |
|
Pulled. Great work @mambocab. |
This PR addresses #33635. The change: when
brew installfails to find a formula, it now searches formula as well as taps.Current behavior:
$ brew install racket Error: No available formula for racket Searching taps... $ brew search racket plt-racketI found myself doing that sort of thing a lot. Now
brew install racketdoes this:$ brew install racket Error: No available formula for racket Searching taps... Searching formulae... plt-racketI could not find documentation for the feature that searches taps after failure to install, which seems like the place to document this feature as well. The same goes for tests. However, in my discussion with @MikeMcQuaid, he indicated tests and documentation might not be necessary for this feature.