Conversation
class OfflineImap < Formula | ||
homepage "http://offlineimap.org/" | ||
url "https://github.com/OfflineIMAP/offlineimap/archive/v6.5.6.tar.gz" | ||
sha1 "cced67060be2922ca3ce056839b2aa1fe6b776a1" | ||
desc "OfflineIMAP is to dispose your mailbox(es) as a local Maildir(s)." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not adding descriptions to existing formulae for now. It's going to be done in bulk in the near future.
@DomT4 Fixed :-) |
@@ -14,6 +12,10 @@ def install | |||
bin.install_symlink libexec+"offlineimap.py" => "offlineimap" | |||
end | |||
|
|||
test do | |||
system bin/"offlineimap", "--version" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this test be modified to do something more substantial than e.g. --version
or --help
? See cmake.rb
for an example of an application formula with a good test and tinyxml2.rb
for an example of a library formula with a good test. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, can you move it below caveats
regardless? Thanks!
Going out now, but I'll look later tonight. But honestly, not sure if I can come up with a better test. Sorta extend beyond my scope. But I'll at least try. |
@MindTooth Thanks! |
@MikeMcQuaid: Really not sure how to create a proper test. The only way I see, is having a dummy IMAP account, and print out a dummy conf-file to use for testing. As for now, I guess as long as it runs, it's okay. But I do see that just pulling the version isn't enough. Thoughts? |
There are some formulae where we can’t really write a test better than |
Cool, that's fine 👍 |
Why aren't we placing this: |
I'll update it later today. etc.install correct? |
Yup. |
With added conformity.
Does it look okay now? :-) |
It's good 👍. Merged in eb13fad, Thanks for your contribution to Homebrew, we appreciate it! 😺. |
With added conformity.
Side note: Best way to run a proper test? Not used to the test portion.