Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

update pushpin formula. original source package had incorrect version number. #40168

Closed
wants to merge 1 commit into from
Closed

Conversation

jkarneges
Copy link
Contributor

No description provided.

@DomT4
Copy link
Member

DomT4 commented May 29, 2015

Is there anything available upstream specifying this was the case, for reference?

@jkarneges
Copy link
Contributor Author

I'm not sure if there's a way to get the history of a tag that was recreated, but here's the commit that was missing from the original source package: fastly/pushpin@1735946

@DomT4
Copy link
Member

DomT4 commented May 29, 2015

Oh, you are the upstream. Sorry, didn't notice when I checked earlier, need more ☕. That's cool, we just like to check in these situations to make sure nothing malicious/suspect happened with the upstream repo.

Ideally a new tag would be less confusing for users/packagers/etc, but I don't see any issue with merging this relatively shortly.

@MikeMcQuaid
Copy link
Member

Thanks for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock!

For future reference the preferred commit message format for simple version updates is pushpin: use new 1.2.0 with correct version..

Also, I really strongly recommend against retagging things. It's hard for people to tell if you've been e.g. hacked, it'll break all people trying to install your software from source until we merge this PR and from Git's perspective if I've cloned your repository it won't update the tag to the correct one without my manually deleting the old tag locally. A better solution for future would be just to tag 1.2.1 or 1.2.0.1

@jkarneges
Copy link
Contributor Author

Thanks for accepting. And great points, Mike. If this ever happens again I'll bump the version rather than try to repair.

@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants