Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

fltk: add devel build. #44880

Closed
wants to merge 1 commit into from
Closed

fltk: add devel build. #44880

wants to merge 1 commit into from

Conversation

dpo
Copy link
Contributor

@dpo dpo commented Oct 13, 2015

Closes #44806.

@dpo
Copy link
Contributor Author

dpo commented Oct 13, 2015 

==> brew audit fltk
==> FAILED
Error: 1 problem in 1 formula
fltk:
 * devel version 1.3.x-r10866 is older than stable version 1.3.3

@bfontaine
Copy link
Contributor

Is 1.3.x-r10866 supposed to be more recent than 1.3.3?

@dpo
Copy link
Contributor Author

dpo commented Oct 13, 2015

Don't think so. That's just how the FLTK folks versioned their development snapshot.

@bfontaine
Copy link
Contributor

As the audit shown we don’t allow devel versions that are older than the stable ones.

@dpo
Copy link
Contributor Author

dpo commented Oct 13, 2015

It's not really older. It's clearly newer because 10.11 is supported. That is the point of this PR.

@bfontaine
Copy link
Contributor

Yeah, just checked upstream; the 1.3.3 version was released in November, 2014 while the 1.3.x-r10866 one was released two weeks ago.

You might use version "1.3.3-r10866" to ensure Hombrew sees it as a newer release.

@dpo
Copy link
Contributor Author

dpo commented Oct 13, 2015

1.3.4-r10866, no?

@bfontaine
Copy link
Contributor

1.3.4-r10866 > 1.3.4 so it won’t work when we’ll update to 1.3.4.

bfontaine
bfontaine reviewed Oct 13, 2015
View reviewed changes
Library/Formula/fltk.rb
stable do
url "https://fossies.org/linux/misc/fltk-1.3.3-source.tar.gz"
sha256 "f8398d98d7221d40e77bc7b19e761adaf2f1ef8bb0c30eceb7beb4f2273d0d97"
depends_on MaximumMacOSRequirement => :yosemite
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the original comment above this line so we know why it’s here:
# Fltk 1.3.4 include support for El Capitan. Remove on update.

@dpo dpo force-pushed the fltk branch 2 times, most recently from ec46018 to 2031e49 Compare October 13, 2015 19:57
@dpo
Copy link
Contributor Author

dpo commented Oct 13, 2015

Done.

bfontaine
bfontaine reviewed Oct 13, 2015
View reviewed changes
Library/Formula/fltk.rb
devel do
url "http://fltk.org/pub/fltk/snapshots/fltk-1.3.x-r10866.tar.gz"
sha256 "4fd4911a1da99c2fa1e6cc0c985b3b8645a7e954802230338fb513ae880ff2cc"
version "1.3.3-r10866" # convince brew that this is older than stable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is newer than stable 😉

@dpo
Copy link
Contributor Author

dpo commented Oct 13, 2015

Sorry ;-). This is the PR that never ends.

bfontaine
bfontaine reviewed Oct 14, 2015
View reviewed changes
Library/Formula/fltk.rb
def install
ENV.universal_binary if build.universal?

if build.devel?
ENV["NOCONFIGURE"] = 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use "1" instead of 1 here. The build fails otherwise.

@dpo
Copy link
Contributor Author

dpo commented Oct 14, 2015

It was so nice and easy with the one-liner ;-).

@dpo
Copy link
Contributor Author

dpo commented Oct 15, 2015

@BrewTestBot test this please

@dpo
Copy link
Contributor Author

dpo commented Oct 16, 2015

All good now. Thanks!

@DomT4
Copy link
Member

DomT4 commented Oct 17, 2015

Merged in 004f134. Thank you for pushing through with this @dpo 😺.

@DomT4 DomT4 closed this in 004f134 Oct 17, 2015
@dpo
Copy link
Contributor Author

dpo commented Oct 17, 2015

Thank you.

@dpo dpo deleted the fltk branch December 16, 2015 19:26
@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dpo @bfontaine @DomT4