lsyncd 2.1.6 #48400
lsyncd 2.1.6 #48400
Conversation
|
Build failed, for some slightly confusing reason: |
|
It looks like they have switched from GNU Autotools to CMake in the 2.1.6 release. The formula will have to be changed to work with the new build system. See the |
nijikon
force-pushed
the
lsyncd
branch
2 times, most recently
from
20ec43a
to
a5ec42e
Compare
|
Need feedback on inreplace and |
nijikon
force-pushed
the
lsyncd
branch
3 times, most recently
from
10c6459
to
c4ae15d
Compare
| args << "-DXNU_DIR=#{buildpath/"xnu"}" | ||
|
|
||
| # DESTINATION bin | ||
| inreplace "CMakeLists.txt", "DESTINATION bin", |
There was a problem hiding this comment.
Why the need to change these? What happens without the inreplace?
There was a problem hiding this comment.
How did I missed this 😡
There was a problem hiding this comment.
You are right, bin inreplace is not needed.
There was a problem hiding this comment.
Bit surprised either of them are. They should be relative to the prefix we pass, which might be problematic for man but cmake is usually intelligent enough to handle that.
There was a problem hiding this comment.
This is why we patch man
==> Finishing up
ln -s ../Cellar/lsyncd/2.1.6/bin/lsyncd lsyncd
Warning: A top-level "man" directory was found
Homebrew requires that man pages live under share.
This can often be fixed by passing "--mandir=#{man}" to configure.
There was a problem hiding this comment.
There's usually a CMake build flag available on this, but if there isn't 👍
There was a problem hiding this comment.
I was not able to find such a flag in this build. Maybe someone more experienced in cmake can take a look. If not then we can pull this.
nijikon
force-pushed
the
lsyncd
branch
2 times, most recently
from
ff7e3e0
to
3564ef1
Compare
Closes Homebrew/legacy-homebrew#48400. Signed-off-by: Tomasz Pajor <tomek@polishgeeks.com>
Closes Homebrew#48400. Signed-off-by: Tomasz Pajor <tomek@polishgeeks.com>
No description provided.