This repository has been archived by the owner. It is now read-only.
Permalink
Browse files

openssl: keg_only you return

  • Loading branch information...
DomT4 committed Jul 12, 2015
1 parent 79fb0b0 commit 2e191b19b8eccfbc031c224892bda140b1b38e7b
Showing with 4 additions and 0 deletions.
  1. +4 −0 Library/Formula/openssl.rb
@@ -5,6 +5,7 @@ class Openssl < Formula
mirror "https://raw.githubusercontent.com/DomT4/LibreMirror/master/OpenSSL/openssl-1.0.2d.tar.gz"
mirror "https://www.mirrorservice.org/sites/ftp.openssl.org/source/openssl-1.0.2d.tar.gz"
sha256 "671c36487785628a703374c652ad2cebea45fa920ae5681515df25d9f2c9a8c8"
revision 1

bottle do
sha256 "e9d8e2c7ab16a8516113093e999c8a6a1bc345badaa48af629963b97a7b9a1ef" => :yosemite
@@ -17,6 +18,9 @@ class Openssl < Formula

depends_on "makedepend" => :build

keg_only :provided_by_osx,
"Apple has deprecated use of OpenSSL in favor of its own TLS and crypto libraries"

def arch_args
{
:x86_64 => %w[darwin64-x86_64-cc enable-ec_nistp_64_gcc_128],

4 comments on commit 2e191b1

@richo

This comment has been minimized.

Copy link
Contributor

richo replied Jul 13, 2015

What's the justification for this? Are "Their own TLS and crypto libraries" meant to mean SecureTransport?

This will almost certainly cause regressions for software that believes linking against openssl will not give it 0.9.8

@DomT4

This comment has been minimized.

Copy link
Contributor Author

DomT4 replied Jul 13, 2015

What's the justification for this?

Clang & LD have fun ideas of what is a reasonable standard linking behaviour to adopt, and it was biting people. See #41613.

We're extremely aware this is going to bite people who have installed things from source over the last 4 days - We've rebottled everything that had OpenSSL links updated during that period and forced revisions. We will be reviewing the situation going forwards in regards to taking more drastic action.

Are "Their own TLS and crypto libraries" meant to mean SecureTransport?

Yup, as well as the archaic OpenSSL they keep slightly supported.

@mistydemeo

This comment has been minimized.

Copy link
Member

mistydemeo replied Jul 13, 2015

This will almost certainly cause regressions for software that believes linking against openssl will not give it 0.9.8

Our usual advice to users wanting to link against this openssl applies: within Homebrew this openssl will automatically be picked up if specified as a dependency, and outside Homebrew we recommend setting CFLAGS and LDFLAGS (as documented in brew info openssl and the postinstall instructions).

Sorry for the inconvenience.

@richo

This comment has been minimized.

Copy link
Contributor

richo replied Jul 13, 2015

Thanks heaps for the clarification, and sorry if I came across bluntly. Justification probably wasn't the right language to use.

Please sign in to comment.