Permalink
Browse files

Don't fails_with_llvm if MacOS.lion?

Not sure how I failed so badly at logic. This should be rewritten so that the build info has a tested MacOS version too. However it seems unlikely that the same LLVM versions on different platforms would have different compile errors. So we'll risk it, and it'll be informative for us too.
  • Loading branch information...
1 parent 1914b89 commit b6aa338e6f52aa53836c834e571ba7f92a65576c @mxcl mxcl committed Sep 2, 2011
@@ -7,7 +7,7 @@ class Elinks < Formula
head 'http://elinks.cz/elinks.git', :using => :git
- fails_with_llvm :build => 2326 if MacOS.lion?
+ fails_with_llvm :build => 2326
def install
ENV.deparallelize
View
@@ -6,7 +6,7 @@ class Lua < Formula
md5 'd0870f2de55d59c1c8419f36e8fac150'
fails_with_llvm "Lua itself compiles with LLVM, but may fail when other software tries to link.",
- :build => 2326 if MacOS.lion?
+ :build => 2326
# Skip cleaning both empty folders and bin/libs so external symbols still work.
skip_clean :all
View
@@ -9,8 +9,7 @@ class Mysql < Formula
depends_on 'readline'
depends_on 'pidof'
- fails_with_llvm "https://github.com/mxcl/homebrew/issues/issue/144",
- :build => 2326 if MacOS.lion?
+ fails_with_llvm "https://github.com/mxcl/homebrew/issues/issue/144", :build => 2326
skip_clean :all # So "INSTALL PLUGIN" can work.
View
@@ -9,7 +9,7 @@ class Node < Formula
# Leopard OpenSSL is not new enough, so use our keg-only one
depends_on 'openssl' if MacOS.leopard?
- fails_with_llvm :build => 2326 if MacOS.lion?
+ fails_with_llvm :build => 2326
# Stripping breaks dynamic loading
skip_clean :all
View
@@ -9,7 +9,7 @@ class Ruby < Formula
depends_on 'readline'
depends_on 'libyaml'
- fails_with_llvm :build => 2326 if MacOS.lion?
+ fails_with_llvm :build => 2326
# Stripping breaks dynamic linking
skip_clean :all
View
@@ -29,7 +29,7 @@ class Wine < Formula
# gnutls not needed since 1.3.16
depends_on 'gnutls' unless ARGV.flag? '--devel' or ARGV.build_head?
- fails_with_llvm :build => 2336 if MacOS.lion?
+ fails_with_llvm :build => 2326
# the following libraries are currently not specified as dependencies, or not built as 32-bit:
# configure: libsane, libv4l, libgphoto2, liblcms, gstreamer-0.10, libcapi20, libgsm, libtiff

2 comments on commit b6aa338

Ruby builds on Lion/Xcode 4.1 with llvm, but I experienced frequent crashes. Installing --use-gcc appears to address the crashes.

Member

mxcl replied Sep 12, 2011

Please open a ticket with crash backtraces.

Please sign in to comment.