This repository has been archived by the owner. It is now read-only.
Permalink
Browse files

Install plists in FormulaInstaller, not build.rb

Build rb should only build!
  • Loading branch information...
mxcl authored and Dennis Luxen committed Sep 12, 2012
1 parent c29eb08 commit e09b32b4e435c165aa850023fa03a2f5212d39a7
Showing with 9 additions and 8 deletions.
  1. +0 −8 Library/Homebrew/build.rb
  2. +9 −0 Library/Homebrew/formula_installer.rb
@@ -146,14 +146,6 @@ def install f
f.prefix.mkpath
f.install
- # Install a plist if one is defined
- unless f.startup_plist.nil?
- unless f.plist_path.exist?
- f.plist_path.write f.startup_plist
- f.plist_path.chmod 0644
- end
- end
-
# Find and link metafiles
FORMULA_META_FILES.each do |filename|
next if File.directory? filename
@@ -186,6 +186,7 @@ def finish
check_PATH unless f.keg_only?
end
+ install_plist
fix_install_names
ohai "Summary" if ARGV.verbose? or show_summary_heading
@@ -283,6 +284,14 @@ def link
end
end
+ def install_plist
+ # Install a plist if one is defined
+ if f.startup_plist and not f.plist_path.exist?
+ f.plist_path.write f.startup_plist
+ f.plist_path.chmod 0644
+ end
+ end
+
def fix_install_names
Keg.new(f.prefix).fix_install_names
rescue Exception => e

0 comments on commit e09b32b

Please sign in to comment.