Permalink
Browse files

Install Git contrib more sensibly

Make caveats refer to persistent locations.
  • Loading branch information...
1 parent 6fb81be commit fff60b5e5ec99882e0ea976de20fb3e72fab2cfe @mxcl mxcl committed Aug 24, 2011
Showing with 4 additions and 4 deletions.
  1. +4 −4 Library/Formula/git.rb
@@ -47,7 +47,7 @@ def install
(share+'doc/git-core/contrib').install 'contrib/emacs'
# Install contrib files to share/contrib
- (share).install 'contrib'
+ (share/:git).install 'contrib'
# These files are exact copies of the git binary, so like the contents
# of libexec/git-core lets hard link them.
@@ -71,10 +71,10 @@ def caveats; <<-EOS.undent
#{etc}/bash_completion.d
Emacs support has been installed to:
- #{share}/doc/git-core/contrib/emacs
+ #{HOMEBREW_PREFIX}/share/doc/git-core/contrib/emacs
- The rest of the "contrib" has been installed to:
- #{share}/contrib
+ The rest of the "contrib" is installed to:
+ #{HOMEBREW_PREFIX}/share/git/contrib
EOS
end
end

3 comments on commit fff60b5

@rosborn
Contributor

Comment on line 49 should say "share/git/contrib", no?

@mxcl
Member
mxcl commented on fff60b5 Aug 25, 2011

Proof that redundant comments are both stupid and a maintenance burden. LIke seriously, who added that comment? The code is perfectly clear.

@Sharpie
Contributor

I'm usually in the "moar comments!" camp. But yeah, WTF.

Please sign in to comment.