This repository has been archived by the owner. It is now read-only.

/legacy-homebrew

External deps are sometimes ignored #12290

Closed
jacknagel opened this Issue May 17, 2012 · 1 comment

Comments

Assignees

@mxcl mxcl

Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@jacknagel @mxcl
@jacknagel
Contributor

jacknagel commented May 17, 2012

When FormulaInstaller is installing dependencies of dependencies, it sets ignore_deps to true because dependencies are expanded recursively by the first FormulaInstaller instance. However, this causes unsatisfied external deps (and other requirements) to be ignored. Compare:

$ brew install open-scene-graph
==> Installing open-scene-graph dependency: gdal
Unsatisfied dependency: numpy
Homebrew does not provide Python dependencies; install with:
  easy_install numpy
==> Downloading http://download.osgeo.org/gdal/gdal-1.9.0.tar.gz

$ brew install gdal
Unsatisfied dependency: numpy
Homebrew does not provide Python dependencies; install with:
  easy_install numpy
Error: An unsatisfied requirement failed this build.

@ghost ghost assigned mxcl Aug 6, 2012

@jacknagel jacknagel referenced this issue Aug 9, 2012

Closed

x11 dep should be fatal #14084

@jacknagel jacknagel closed this in 50090dd Aug 15, 2012

@jacknagel

This comment has been minimized.

Show comment Hide comment
@jacknagel

jacknagel Aug 15, 2012

Contributor

Fixed by 50090dd

Contributor

jacknagel commented Aug 15, 2012

Fixed by 50090dd

fgeller added a commit to fgeller/homebrew that referenced this issue Aug 22, 2012

@jacknagel @fgeller
Recursively expand requirements in FormulaInstaller 
Currently FormulaInstaller "forgets" about the requirements of
dependencies, as dependencies are recursively expanded by the first
FormulaInstaller instance, and then ignored by subsequent instances to
prevent duplicate installation attempts. These requirements then have
their messages displayed, but the fatal check is skipped and thus no
exception is raised.

Now that we have Formula#recursive_requirements, we can mirror what we
are doing with dependencies and recursively expand requirements up
front.

While at it, fix a bug in determining Requirement equality that resulted
in unique requirements being eliminated from a formula's set of
recursive requirements.

Fixes #12290.
Fixes #14084.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
c76241c

Sharpie pushed a commit to Sharpie/homebrew that referenced this issue Sep 11, 2012

@jacknagel
Recursively expand requirements in FormulaInstaller 
Currently FormulaInstaller "forgets" about the requirements of
dependencies, as dependencies are recursively expanded by the first
FormulaInstaller instance, and then ignored by subsequent instances to
prevent duplicate installation attempts. These requirements then have
their messages displayed, but the fatal check is skipped and thus no
exception is raised.

Now that we have Formula#recursive_requirements, we can mirror what we
are doing with dependencies and recursively expand requirements up
front.

While at it, fix a bug in determining Requirement equality that resulted
in unique requirements being eliminated from a formula's set of
recursive requirements.

Fixes #12290.
Fixes #14084.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
b4d1eaf

snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this issue Dec 17, 2012

@jacknagel
Recursively expand requirements in FormulaInstaller 
Currently FormulaInstaller "forgets" about the requirements of
dependencies, as dependencies are recursively expanded by the first
FormulaInstaller instance, and then ignored by subsequent instances to
prevent duplicate installation attempts. These requirements then have
their messages displayed, but the fatal check is skipped and thus no
exception is raised.

Now that we have Formula#recursive_requirements, we can mirror what we
are doing with dependencies and recursively expand requirements up
front.

While at it, fix a bug in determining Requirement equality that resulted
in unique requirements being eliminated from a formula's set of
recursive requirements.

Fixes #12290.
Fixes #14084.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
bfdd2a4

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.