Standardize more option names #14145

Closed
jacknagel opened this Issue Aug 13, 2012 · 7 comments

Comments

Projects
None yet
5 participants
Contributor

jacknagel commented Aug 13, 2012

"universal" and "32-bit" are built into the new options code; we should consider standardizing a few more options.

Going through formulae, I notice that there are a lot of variations on "--with-docs": "--doc", "--docs", "--build-docs"; we should pick one.

The same thing goes for "--with-x" and friends.

Member

mxcl commented Aug 14, 2012

Once standardized we need to support the old forms for formula that had them, rationale being, otherwise they won't upgrade with previous options.

Contributor

jacknagel commented Aug 14, 2012

This is true.

Contributor

adamv commented Aug 22, 2012

From the optional & feature work, I propose:

  • with/without-dep
  • enable/disable-feature
Contributor

jacknagel commented Aug 29, 2012

We can run option names through a canonicalization function when we read them from the tab.

Contributor

jacknagel commented Jan 26, 2013

Coming back to this, ideally we'd have a normalizer on the reading side so that we can transition things that are named differently to the optional/recommended dep syntax, and also to use the with?/without? methods on build and any future enhancement to that.

In addition to normalizing what we can safely, we might want to pick 0.9.6 (or something) to be a flag day for misnamed options.

Owner

MikeMcQuaid commented Jan 26, 2013

Sounds sensible.

Contributor

samueljohn commented Sep 4, 2013

Sorry for digging this out. We tend to favor with/without now, even for stuff like --with-doc as we have implemented some logic around that (for example depends_on 'foo' => 'with-bar' works also if foo has bar on and provides only a --without-bar option. We don't have this for enable/disable right now.
This will work as long as there is a formula named doc and then it really gets confusing.

Don't hit me, but actually I do like Macport's +bar and -bar syntax, because it's shorter than --with-bar, --without-bar or even --enable-bar,--disable-bar.

jacknagel closed this May 9, 2014

xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.