This repository has been archived by the owner. It is now read-only.

depends_on :stdenv #14654

Closed
2bits opened this Issue Sep 3, 2012 · 13 comments

Comments

Projects
None yet
6 participants
Contributor

2bits commented Sep 3, 2012

We probably could use depends_on :stdenv
You can imagine why I suppose.

Contributor

adamv commented Sep 3, 2012

This.

Member

mxcl commented Sep 3, 2012

Yes, I intended something like this, but am not the DSL king in Formula. I am scared of that class in general.

Though it is not a solution to superenv bugs, the solution to those is for me to fix them. There are only a few formula that will probably need this.

Also, finally, is this really a depends_on thing? Let's not force everything in there. stdenv is not something you can install, like x11 or the CLT. It is a homebrew environment feature, a different DSL. Like:

env :std
Contributor

2bits commented Sep 3, 2012

That makes more sense, ENV.std. Some of the apps (from memory):

  • graphviz
  • guile
  • solfege
  • pango
Contributor

samueljohn commented Sep 3, 2012

I am currently working on python to make it work with superenv. Right now I still get building dbm using ndbm error: /usr/include/zlib.h: No such file or directory. I still have to get superenv into my head.

Member

mxcl commented Sep 3, 2012

  • pango is fixed.
  • The Solfege is not a superenv bug, it's an X11 dependency bug.
  • Graphviz is already excluded (build.rb has a blacklist).
  • guile is fixed (brew update, recent change fixed it, essentially it was a regression)

I am currently working on python to make it work with superenv. Right now I still get building dbm using ndbm
error: /usr/include/zlib.h: No such file or directory. I still have to get superenv into my head.

Sounds like a NCLT issue and not a superenv issue to me. Something is requesting an explicit path to /usr/include/zlib.h.

superenv (should) be easy to understand: Nothing is set, any issues you then have can be fixed by setting stuff (eg. CPPFLAGS). If it seems hard to understand then I've not explained it well enough, but essentially it shouldn't require any difficult thinking. The problems so far have been bugs.

Contributor

samueljohn commented Sep 4, 2012

@mxcl I got it :-) Was confused because python was blacklisted and actually uses the old std env. The problem was not superenv but python only looking through -I flags to find zlib.h on NCLT systems. There is a PR #14689 for this now.

I am no longer trying to make python superenv compatible, because I'd need to essentially recreate the vars as they are in --env=std, so I think it's best to stick with that.

Member

mxcl commented Sep 4, 2012

I plan to improve stdenv with some lessons learned making superenv, so the current issues with python attributed to stdenv should be fixable.

Stdenv will always exist as it is flexible, where superenv is not. Instead superenv is reliable (with a little more work).

Contributor

mistydemeo commented Sep 10, 2012

Related: --32-bit should always imply stdenv. (At the moment builds which request a 32-bit build are broken unless the user also passes --env=std, which is counter-intuitive.)

Member

mxcl commented Sep 13, 2012

superenv can support this, just as a general design goal it was not flexible, with the end that options would be added as they were discovered to still be necessary.

Contributor

adamv commented Sep 14, 2012

Member

mxcl commented Sep 14, 2012

Great. Merge.

Though I don't think we need env :x11 anymore, and maybe that's even a bad idea. You should only be able to add the X11 env by depending on it.

Contributor

adamv commented Sep 14, 2012

Ok, will clean this up and then merge. Hopefully won't cause jack too much merge pain.

Contributor

jacknagel commented Sep 14, 2012

Go for it, I don't think my work touches much code in this area.

@adamv adamv closed this in c6f30a7 Sep 14, 2012

Sharpie pushed a commit to Sharpie/homebrew that referenced this issue Sep 15, 2012

snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this issue Dec 17, 2012

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.