Mutt 1.5.21 Patch Issue #16461

Closed
ndegruchy opened this Issue Dec 7, 2012 · 1 comment

2 participants

@ndegruchy

When trying to execute brew install mutt --ignore-thread-patch --trash-patch --sidebar-patch it fails with the following output:

==> Downloading ftp://ftp.mutt.org/mutt/devel/mutt-1.5.21.tar.gz
Already downloaded: /Users/ndegruchy/Library/Caches/Homebrew/mutt-1.5.21.tar.gz
==> Downloading patches
==> Patching
patching file buffy.c
patching file buffy.h
patching file color.c
patching file compose.c
patching file configure.ac
patching file curs_main.c
patching file flags.c
patching file functions.h
patching file globals.h
patching file handler.c
patching file init.h
patching file mailbox.h
patching file main.c
patching file Makefile.am
patching file Makefile.in
patching file mbox.c
patching file menu.c
patching file mh.c
patching file mutt_curses.h
patching file mutt_menu.h
patching file mutt.h
patching file muttlib.c
patching file mx.c
patching file mx.h
patching file OPS
patching file pager.c
patching file pattern.c
patching file PATCHES
patching file protos.h
patching file sidebar.c
patching file sidebar.h
patching file doc/Muttrc
patching file imap/imap.c
patching file imap/command.c
patching file commands.c
patching file flags.c
Hunk #1 succeeded at 67 (offset 2 lines).
Hunk #2 succeeded at 95 (offset 2 lines).
patching file globals.h
Hunk #1 succeeded at 141 with fuzz 1 (offset 2 lines).
patching file imap/message.c
patching file init.h
Hunk #1 succeeded at 3237 (offset 42 lines).
patching file mutt.h
Hunk #2 succeeded at 711 (offset 3 lines).
Hunk #3 succeeded at 885 (offset 4 lines).
patching file muttlib.c
Hunk #1 succeeded at 1563 (offset 48 lines).
patching file mx.c
Hunk #1 succeeded at 794 (offset 18 lines).
Hunk #2 succeeded at 981 (offset 22 lines).
Hunk #3 succeeded at 1006 (offset 22 lines).
Hunk #4 succeeded at 1211 (offset 22 lines).
patching file postpone.c
patching file OPS
Hunk #1 FAILED at 179.
1 out of 1 hunk FAILED -- saving rejects to file OPS.rej
patching file copy.c
patching file curs_main.c
Hunk #1 succeeded at 323 (offset 2 lines).
Hunk #2 succeeded at 336 (offset 2 lines).
Hunk #3 succeeded at 350 (offset 2 lines).
Hunk #4 succeeded at 425 (offset 2 lines).
Hunk #5 succeeded at 1214 (offset 22 lines).
Hunk #6 succeeded at 1514 (offset 22 lines).
Hunk #7 succeeded at 1770 (offset 22 lines).
Hunk #8 succeeded at 1829 (offset 22 lines).
Hunk #9 succeeded at 1860 (offset 22 lines).
patching file flags.c
Hunk #1 succeeded at 271 (offset 19 lines).
patching file functions.h
Hunk #1 succeeded at 167 with fuzz 1.
Hunk #2 succeeded at 219 (offset 5 lines).
patching file hdrline.c
patching file imap/imap.c
patching file imap/message.c
Hunk #3 succeeded at 1056 (offset 2 lines).
Hunk #4 succeeded at 1226 (offset 2 lines).
Hunk #5 succeeded at 1241 (offset 2 lines).
patching file imap/message.h
patching file mailbox.h
Hunk #1 succeeded at 29 with fuzz 2 (offset 1 line).
patching file mbox.c
Hunk #1 succeeded at 1222 (offset 2 lines).
patching file mutt.h
Hunk #2 succeeded at 197 (offset 1 line).
Hunk #3 succeeded at 749 (offset 6 lines).
patching file pager.c
Hunk #1 succeeded at 2308 (offset 20 lines).
patching file parse.c
patching file protos.h
Hunk #1 succeeded at 69 (offset 7 lines).
patching file sort.c
patching file thread.c
Error: Failure while executing: /usr/bin/patch -f -p1 -i 002-homebrew.diff

Doing it without the --ignore-thread-patch succeeds and begins compiling normally. Is the ignore-threads patch incompatible with the rest? Could it be made mutually exclusive to the other options?

@adamv

Could it be made mutually exclusive to the other options?

Sure, a patch would be welcome for this!

@yourabi yourabi added a commit that referenced this issue Jan 19, 2013
@yourabi yourabi make sure ignore-thread-patch and sidebar-patch are mutually exclusiv…
…e since applying both causes build failure addresses #16461. Migrate to new style options and normalize option names resolving brew audit warnings
d066ce9
@adamv adamv added a commit that closed this issue Jan 19, 2013
@yourabi yourabi mutt: make thread/sidebar patches mutually exclusive
Fixes #16461.
Closes #17182.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
054f155
@adamv adamv closed this in 054f155 Jan 19, 2013
@asharpe asharpe pushed a commit that referenced this issue Jan 20, 2013
@yourabi yourabi mutt: make thread/sidebar patches mutually exclusive
Fixes #16461.
Closes #17182.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
6b0055b
@norioxkimura norioxkimura added a commit to norioxkimura/homebrew that referenced this issue Jan 26, 2013
@yourabi yourabi mutt: make thread/sidebar patches mutually exclusive
Fixes #16461.
Closes #17182.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
bb952cc
@rajeeja rajeeja pushed a commit that referenced this issue Apr 19, 2013
@yourabi yourabi mutt: make thread/sidebar patches mutually exclusive
Fixes #16461.
Closes #17182.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
e3b215f
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.