Remove mosml #17210

Closed
adamv opened this Issue Jan 20, 2013 · 9 comments

Projects

None yet

5 participants

@adamv
Contributor
adamv commented Jan 20, 2013

mosml installs a config.h file directly to include, which breaks other software.

I havent been able to get this to install cleanly on Snow Leopard either.

MacPorts patches mosml to install in a more self-contained way, but no one has volunteered to adapt these patches for Homebrew.

So, I'm going to redact mosml from Homebrew and close the related tickets.

@samueljohn
Contributor

I don't mind. An option would be to mark as keg_only, right?

@adamv
Contributor
adamv commented Jan 20, 2013

People could still brew link it and cause problems; the MacPorts patches have it right here, changing the include folders. But since I don't use this software I'm too lazy to port the patches.

@samueljohn
Contributor

Agreed. Boneyard?

@cooljeanius

Ping @kirneh1986 who originally submitted this formula

@kirneh1986
Contributor

Well, I don't have it installed anymore myself, so I'm probably too lazy as well :) I don't mind you removing it

@adamv adamv added a commit that closed this issue Jan 30, 2013
@adamv adamv Remove mosml.
Closes #17210.
Closes #16596.
Closes #13282.
5648ae5
@adamv adamv closed this in 5648ae5 Jan 30, 2013
@neil-s
neil-s commented Jan 31, 2013

Oh what timing, I was just installing it using brew, got an error, so I updated brew and voila, deleted formulae contains 'mosml'. If you could give me a few pointers as to how to get started adapting the MacPorts patch to Homebrew, I'd love to make my first real contribution to open source!

@cooljeanius

If you could give me a few pointers as to how to get started adapting the MacPorts patch to Homebrew,

Well the patches they use can be found at: https://svn.macports.org/repository/macports/trunk/dports/lang/mosml/files/

@samueljohn
Contributor

Cool if you do this @neil-s!

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.