This repository has been archived by the owner. It is now read-only.

Detect version from git tag #18300

Closed
adamv opened this Issue Mar 7, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@adamv
Contributor

adamv commented Mar 7, 2013

Not sure how this would work, since we detect versions off of the URL, but when we have url 'thing', :tag => 'wad', the version should somehow auto-detect to wad.

@jacknagel

This comment has been minimized.

Show comment Hide comment
@jacknagel

jacknagel Mar 8, 2013

Contributor

I agree.

Some tags have leading text ("v", for example), and the version parser currently assumes a pathname, so

[1] 1.8.7 brew(main)> Version.parse("v1.1.1")
=> #<Version:0x12477cc @detected_from_url=true, @version="1.1">

doesn't produce the desired result. Needs some work.

Contributor

jacknagel commented Mar 8, 2013

I agree.

Some tags have leading text ("v", for example), and the version parser currently assumes a pathname, so

[1] 1.8.7 brew(main)> Version.parse("v1.1.1")
=> #<Version:0x12477cc @detected_from_url=true, @version="1.1">

doesn't produce the desired result. Needs some work.

@jacknagel jacknagel closed this in a16c80a Jun 29, 2013

handyman5 pushed a commit to handyman5/homebrew that referenced this issue Oct 7, 2013

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.