This repository has been archived by the owner. It is now read-only.

disco does not compile #18646

Closed
alexcepoi opened this Issue Mar 21, 2013 · 9 comments

Comments

Projects
None yet
4 participants
@alexcepoi

alex@mac ~ $ brew install disco
==> Downloading https://github.com/tuulos/disco/tarball/0.3.2
Already downloaded: /Library/Caches/Homebrew/disco-0_3_2.tgz
==> make
==> make install
==> make install-discodb install-discodex
return c;
^
19 errors generated.
error: command 'cc' failed with exit status 1
make: *** [install-discodb] Error 1

READ THIS: https://github.com/mxcl/homebrew/wiki/troubleshooting

alex@mac ~ $ brew doctor
Your system is raring to brew.

@adamv

This comment has been minimized.

Show comment Hide comment
@adamv

adamv Mar 21, 2013

Contributor

READ THIS: https://github.com/mxcl/homebrew/wiki/troubleshooting

Need full verbose output in a gist.

(Compilation worked for me on Lion.)

Contributor

adamv commented Mar 21, 2013

READ THIS: https://github.com/mxcl/homebrew/wiki/troubleshooting

Need full verbose output in a gist.

(Compilation worked for me on Lion.)

@alexcepoi

This comment has been minimized.

Show comment Hide comment
@alexcepoi

alexcepoi Mar 21, 2013

It fails for me on Mountain Lion.

Here is the output you wanted: https://gist.github.com/alexcepoi/82b2ee062ad0a0b72dd2
Could not find anything in ~/Library/Logs/Homebrew/disco/

It fails for me on Mountain Lion.

Here is the output you wanted: https://gist.github.com/alexcepoi/82b2ee062ad0a0b72dd2
Could not find anything in ~/Library/Logs/Homebrew/disco/

@samueljohn

This comment has been minimized.

Show comment Hide comment
@samueljohn

samueljohn Mar 22, 2013

Contributor

Does it work if you brew install disco --use-llvm ? Or with --env=std ?

Contributor

samueljohn commented Mar 22, 2013

Does it work if you brew install disco --use-llvm ? Or with --env=std ?

@alexcepoi

This comment has been minimized.

Show comment Hide comment
@alexcepoi

alexcepoi Mar 22, 2013

works with --use-llvm :)

On Mar 22, 2013, at 11:48 PM, Samuel John notifications@github.com wrote:

Does it work if you brew install disco --use-llvm ? Or with --env=std ?


Reply to this email directly or view it on GitHub.

works with --use-llvm :)

On Mar 22, 2013, at 11:48 PM, Samuel John notifications@github.com wrote:

Does it work if you brew install disco --use-llvm ? Or with --env=std ?


Reply to this email directly or view it on GitHub.

@adamv

This comment has been minimized.

Show comment Hide comment
@adamv

adamv Mar 25, 2013

Contributor

NOTE: this should be changed to using the official download, not a fork: https://github.com/discoproject/disco/tags and probably someone should try to update to 0.4.4.

Contributor

adamv commented Mar 25, 2013

NOTE: this should be changed to using the official download, not a fork: https://github.com/discoproject/disco/tags and probably someone should try to update to 0.4.4.

@apjanke

This comment has been minimized.

Show comment Hide comment
@apjanke

apjanke Mar 29, 2013

Contributor

Fails for me on Mountain Lion with same error as @alexcepol, even with --use-llvm. Were any other changes needed?

Can't update to 0.4.4 or 0.4.5, at least not easily. They've changed their build system to use "rebar", and it looks like it only works when run from an active git repo that's linked to their project, using git during the build process to annotate stuff and to pull down additional submodule files for the contrib/ dir. As of 0.4.2, the discodex and discodb in contrib/, which the current formula installs, are broken out of the main project to to submodules. Would need to remove the discodb and discodex parts to upgrade past 0.4.1.

Contributor

apjanke commented Mar 29, 2013

Fails for me on Mountain Lion with same error as @alexcepol, even with --use-llvm. Were any other changes needed?

Can't update to 0.4.4 or 0.4.5, at least not easily. They've changed their build system to use "rebar", and it looks like it only works when run from an active git repo that's linked to their project, using git during the build process to annotate stuff and to pull down additional submodule files for the contrib/ dir. As of 0.4.2, the discodex and discodb in contrib/, which the current formula installs, are broken out of the main project to to submodules. Would need to remove the discodb and discodex parts to upgrade past 0.4.1.

@apjanke apjanke referenced this issue in apjanke/legacy-homebrew Mar 29, 2013

Closed

Get disco >= 0.4.2 building #1

@apjanke

This comment has been minimized.

Show comment Hide comment
@apjanke

apjanke Apr 11, 2013

Contributor

Okay, I've got disco building now, with version 0.4.5. It's on branch https://github.com/apjanke/homebrew/tree/upgrade-disco-0_4_5

  • Upgrades disco to 0.4.5
  • Breaks discodex out to a separate formula, since it's now a separate project on github.
  • Fixes python installation locations
  • Switches from the fork to the main discoproject download

This would be a breaking change for current users of discodex, so I don't know if there needs to be a notification or something before pulling this in to the main homebrew repo.

Contributor

apjanke commented Apr 11, 2013

Okay, I've got disco building now, with version 0.4.5. It's on branch https://github.com/apjanke/homebrew/tree/upgrade-disco-0_4_5

  • Upgrades disco to 0.4.5
  • Breaks discodex out to a separate formula, since it's now a separate project on github.
  • Fixes python installation locations
  • Switches from the fork to the main discoproject download

This would be a breaking change for current users of discodex, so I don't know if there needs to be a notification or something before pulling this in to the main homebrew repo.

@adamv

This comment has been minimized.

Show comment Hide comment
@adamv

adamv Apr 13, 2013

Contributor

@apjanke can you open this as a new pull request?

Contributor

adamv commented Apr 13, 2013

@apjanke can you open this as a new pull request?

@apjanke

This comment has been minimized.

Show comment Hide comment
@apjanke

apjanke Apr 15, 2013

Contributor

Pull request opened: mxcl#19202

Contributor

apjanke commented Apr 15, 2013

Pull request opened: mxcl#19202

@adamv adamv closed this in 198f752 May 14, 2013

handyman5 pushed a commit to handyman5/homebrew that referenced this issue Oct 7, 2013

disco 0.4.5
Disco 0.3.2 was not building. This addresses it by jumping to a new version.
* Upgrades disco to version 0.4.5.
* Breaks the discodex project out to a separate formula, corresponding
to its reorganization opn GitHub.
* Fixes Python installation paths by passing PY_INSTALL_OPTS through the
Makefile.
* Switches from inreplace() to a patch.
* Uses the official discoproject download instead of the tuulos fork.

Closes #19202.
Fixes #18646.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.