This repository has been archived by the owner. It is now read-only.

SVN: Generate Language bindings as well #43

Closed
fjakobs opened this Issue Sep 8, 2009 · 15 comments

Comments

Projects
None yet
4 participants
@fjakobs
Contributor

fjakobs commented Sep 8, 2009

I have to use "git svn" but this will not work without the SVN perl bindings.

Right now the svn package does not build and install any language bindings. The python, ruby and Java bindings could be interesting as well.

@mxcl

This comment has been minimized.

Show comment
Hide comment
@mxcl

mxcl Sep 11, 2009

Member

Agreed.

Member

mxcl commented Sep 11, 2009

Agreed.

@adamv

This comment has been minimized.

Show comment
Hide comment
@adamv

adamv Sep 11, 2009

Contributor

Looks like SWIG is a pre-req for brewing the bindings; here's a SWIG formula:
http://github.com/adamv/homebrew/commit/73fc4f5d6571f37a879b86091ff1a43034e2662d

(Still need to update this recipe, maybe with a --option for bindings/no-bindings.)

Contributor

adamv commented Sep 11, 2009

Looks like SWIG is a pre-req for brewing the bindings; here's a SWIG formula:
http://github.com/adamv/homebrew/commit/73fc4f5d6571f37a879b86091ff1a43034e2662d

(Still need to update this recipe, maybe with a --option for bindings/no-bindings.)

@fjakobs

This comment has been minimized.

Show comment
Hide comment
@fjakobs

fjakobs Sep 11, 2009

Contributor

I have swig already installed in /usr/bin (version 1.3.31)

Maybe we don't need it if it already comes with (Snow) Leopard.

Contributor

fjakobs commented Sep 11, 2009

I have swig already installed in /usr/bin (version 1.3.31)

Maybe we don't need it if it already comes with (Snow) Leopard.

@mxcl

This comment has been minimized.

Show comment
Hide comment
@mxcl

mxcl Sep 30, 2009

Member

It's on 10.5 too as it turns out.

The problem here is that Homebrew policy is not to duplicate what is in CPAN, Python Easy_install and Ruby gems. And I'm sure the language bindings are there.

We could force their installation as part of the git formula's install. But that seems heavy handed perhaps.

Member

mxcl commented Sep 30, 2009

It's on 10.5 too as it turns out.

The problem here is that Homebrew policy is not to duplicate what is in CPAN, Python Easy_install and Ruby gems. And I'm sure the language bindings are there.

We could force their installation as part of the git formula's install. But that seems heavy handed perhaps.

@mxcl

This comment has been minimized.

Show comment
Hide comment
@mxcl

mxcl Sep 30, 2009

Member

Also subversion is a duplicate formula itself. Is the system subversion not sufficient here?

Member

mxcl commented Sep 30, 2009

Also subversion is a duplicate formula itself. Is the system subversion not sufficient here?

@adamv

This comment has been minimized.

Show comment
Hide comment
@adamv

adamv Sep 30, 2009

Contributor

Subversion 10.5 is 1.4.x which is lacking features compared to 1.6. that I imagine some people use.
And whenever 1.7.x comes out the same will apply to Snow Leoaprd.

Contributor

adamv commented Sep 30, 2009

Subversion 10.5 is 1.4.x which is lacking features compared to 1.6. that I imagine some people use.
And whenever 1.7.x comes out the same will apply to Snow Leoaprd.

@fjakobs

This comment has been minimized.

Show comment
Hide comment
@fjakobs

fjakobs Sep 30, 2009

Contributor

There seems to be a rather old (1.4.6) version of the svn bindings in CPAN as "Alien::SVN" but it doesn't even build on my machine. I think we cannot rely on this version. Further it would not solve my issue because I need the svn bindings to build git with svn support and I don't think it is a good idea to ask the user to install this manually before building git.

Contributor

fjakobs commented Sep 30, 2009

There seems to be a rather old (1.4.6) version of the svn bindings in CPAN as "Alien::SVN" but it doesn't even build on my machine. I think we cannot rely on this version. Further it would not solve my issue because I need the svn bindings to build git with svn support and I don't think it is a good idea to ask the user to install this manually before building git.

@mxcl

This comment has been minimized.

Show comment
Hide comment
@mxcl

mxcl Sep 30, 2009

Member

Oh well, I guess this means CPAN sucks for some stuff. So our policy of no duplication doesn't always make sense. Consider it revised.

Still I'm not fixing this particular issue as I don't know how. Anyone got the knowledge?

Member

mxcl commented Sep 30, 2009

Oh well, I guess this means CPAN sucks for some stuff. So our policy of no duplication doesn't always make sense. Consider it revised.

Still I'm not fixing this particular issue as I don't know how. Anyone got the knowledge?

@kbrock

This comment has been minimized.

Show comment
Hide comment
@kbrock

kbrock Jan 6, 2010

Contributor

Is there a way to leverage the macports package?

either translating the portage file or something like that?

Contributor

kbrock commented Jan 6, 2010

Is there a way to leverage the macports package?

either translating the portage file or something like that?

@adamv

This comment has been minimized.

Show comment
Hide comment
@adamv

adamv Jan 16, 2010

Contributor

One problem with building the language bindings is, which interpreters do you build against?

If you just build swig-py naively, it will work against OS X's Framework Python. Which may be what the user wants, if they are not using a custom newer Python. Or, the user may want to use the Homebrew Python... if it exists, but we're certainly not going to put a Python dep in Subversion.

Macports has separate ports for the language bindings which, no surprise here, each pull down a Macports-specific version of that language.

Additional issues: The Perl bindings don't respect the specified GCC/LLVM, so fail on mmx/core2 CFLAGS.

I've posted some naive code here, in case someone wants to take it up:
http://github.com/adamv/homebrew/tree/subversion-bindings

After this investigation, I'm inclined to vote "-1" on including the language bindings.

Contributor

adamv commented Jan 16, 2010

One problem with building the language bindings is, which interpreters do you build against?

If you just build swig-py naively, it will work against OS X's Framework Python. Which may be what the user wants, if they are not using a custom newer Python. Or, the user may want to use the Homebrew Python... if it exists, but we're certainly not going to put a Python dep in Subversion.

Macports has separate ports for the language bindings which, no surprise here, each pull down a Macports-specific version of that language.

Additional issues: The Perl bindings don't respect the specified GCC/LLVM, so fail on mmx/core2 CFLAGS.

I've posted some naive code here, in case someone wants to take it up:
http://github.com/adamv/homebrew/tree/subversion-bindings

After this investigation, I'm inclined to vote "-1" on including the language bindings.

@mxcl

This comment has been minimized.

Show comment
Hide comment
@mxcl

mxcl Jan 17, 2010

Member

We need them, something as common used as git-svn is required.

I'm not too interested in supporting the use case where the python bindings use the newer Python that the user installed themselves. I think we can safely just force them to use the Python installed with the system. This is much safer for us too.

Also I don't know what the mxcl of 30th Sept was talking about. I doubt these come as gems or pypi eggs.

So the sooner someone can finish this patch the better. Preferably someone who needs it. I wouldn't know how to test it.

Member

mxcl commented Jan 17, 2010

We need them, something as common used as git-svn is required.

I'm not too interested in supporting the use case where the python bindings use the newer Python that the user installed themselves. I think we can safely just force them to use the Python installed with the system. This is much safer for us too.

Also I don't know what the mxcl of 30th Sept was talking about. I doubt these come as gems or pypi eggs.

So the sooner someone can finish this patch the better. Preferably someone who needs it. I wouldn't know how to test it.

@fjakobs

This comment has been minimized.

Show comment
Hide comment
@fjakobs

fjakobs Jan 17, 2010

Contributor

I'm working on it on my "git-svn" branch http://github.com/fjakobs/homebrew/commits/git-svn. Its functional now but needs some more polishing.

Contributor

fjakobs commented Jan 17, 2010

I'm working on it on my "git-svn" branch http://github.com/fjakobs/homebrew/commits/git-svn. Its functional now but needs some more polishing.

@kbrock

This comment has been minimized.

Show comment
Hide comment
@kbrock

kbrock Jan 18, 2010

Contributor

Did someone already fix this?

I updated svn then git and git-svn is working.
I even renamed my old /opt/local to something else, but all seems to work.

Contributor

kbrock commented Jan 18, 2010

Did someone already fix this?

I updated svn then git and git-svn is working.
I even renamed my old /opt/local to something else, but all seems to work.

@fjakobs

This comment has been minimized.

Show comment
Hide comment
@fjakobs

fjakobs Jan 19, 2010

Contributor

It looks like OSX 10.6 comes with the perl svn bindings pre installed under

/System/Library/Perl/Extras/5.10.0/darwin-thread-multi-2level/SVN/

I've checked it on three Macs with 10.6 and all of them have this directory. We can could use the formulas from my branch for OSX >10.6 but I personally don't care too much.

Contributor

fjakobs commented Jan 19, 2010

It looks like OSX 10.6 comes with the perl svn bindings pre installed under

/System/Library/Perl/Extras/5.10.0/darwin-thread-multi-2level/SVN/

I've checked it on three Macs with 10.6 and all of them have this directory. We can could use the formulas from my branch for OSX >10.6 but I personally don't care too much.

@adamv

This comment has been minimized.

Show comment
Hide comment
@adamv

adamv May 13, 2010

Contributor

Given that the git-svn case is handled for 10.6, and we just added the Java bindings to the formula, I'm going to close this. If people on 10.5 need git-svn support, or anyone needs other language bindings, they can complain/submit a patch.

Contributor

adamv commented May 13, 2010

Given that the git-svn case is handled for 10.6, and we just added the Java bindings to the formula, I'm going to close this. If people on 10.5 need git-svn support, or anyone needs other language bindings, they can complain/submit a patch.

bholt pushed a commit to bholt/homebrew that referenced this issue Feb 25, 2014

@Homebrew Homebrew locked and limited conversation to collaborators Feb 16, 2016

This issue was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.