Bottle ocaml? #9841

Closed
jacknagel opened this Issue Jan 29, 2012 · 13 comments

3 participants

@jacknagel

ocaml has a pretty length build, and it has no dependencies or options. Candidate for bottling?

@adamv

I'd say so.

@MikeMcQuaid
Homebrew member

Seems good.

@MikeMcQuaid
Homebrew member

Any others spring to mind? Happy to do a few today.

@adamv

SBCL maybe

@jacknagel

Hmm, just noticed that the ocaml formula does this:

# site-lib in the Cellar will be a symlink to the HOMEBREW_PREFIX location
(HOMEBREW_PREFIX+"lib/ocaml/site-lib").mkpath
ln_s HOMEBREW_PREFIX+"lib/ocaml/site-lib", lib+"ocaml/site-lib"

Not sure how that is going to gel with bottling.

@MikeMcQuaid
Homebrew member

As long as HOMEBREW_PREFIX is default (which I can add back in) and nothing is installed in there that shouldn't be a problem?

@jacknagel

(HOMEBREW_PREFIX+"lib/ocaml/site-lib").mkpath won't happen when installing from the bottle though, right?

@MikeMcQuaid
Homebrew member

Indeed. The symlink should be there though, not sure if that's enough.

@MikeMcQuaid
Homebrew member

Can you think of a suitable test? Other possible candidates for bottling: valgrind, mysql, pkg-config, readline, git.

@MikeMcQuaid
Homebrew member

Bottles for testing:
sbcl: mikemcquaid/homebrew@57cabd8
objective-caml: mikemcquaid/homebrew@7960cef

@jacknagel

I think we can mkpath the ocaml site-lib directory in the keg linking code.

@jacknagel

See 172c05e; ocaml bottle should be a go.

@MikeMcQuaid MikeMcQuaid added a commit that closed this issue Jan 31, 2012
@MikeMcQuaid MikeMcQuaid Add objective-caml bottle.
Closes #9841.
0f45ece
@MikeMcQuaid MikeMcQuaid added a commit that referenced this issue Jan 31, 2012
@MikeMcQuaid MikeMcQuaid Add sbcl bottle.
Result of discussion in #9841.
cf9f65d
@MikeMcQuaid
Homebrew member

Added. Anything else worth bottling?

@mneise mneise pushed a commit that referenced this issue Mar 19, 2012
@MikeMcQuaid MikeMcQuaid Add objective-caml bottle.
Closes #9841.
ed4ee94
@mneise mneise pushed a commit that referenced this issue Mar 19, 2012
@MikeMcQuaid MikeMcQuaid Add sbcl bottle.
Result of discussion in #9841.
9e5fc89
@cacoco cacoco added a commit that referenced this issue Mar 24, 2012
@MikeMcQuaid MikeMcQuaid Add objective-caml bottle.
Closes #9841.
71f6c16
@cacoco cacoco added a commit that referenced this issue Mar 24, 2012
@MikeMcQuaid MikeMcQuaid Add sbcl bottle.
Result of discussion in #9841.
3876aba
@Sharpie Sharpie pushed a commit to Sharpie/homebrew that referenced this issue Sep 12, 2012
@MikeMcQuaid MikeMcQuaid Add objective-caml bottle.
Closes #9841.
1cbc8be
@Sharpie Sharpie pushed a commit to Sharpie/homebrew that referenced this issue Sep 12, 2012
@MikeMcQuaid MikeMcQuaid Add sbcl bottle.
Result of discussion in #9841.
d8badaa
@snakeyroc3 snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this issue Dec 17, 2012
@MikeMcQuaid MikeMcQuaid Add objective-caml bottle.
Closes #9841.
08b5115
@snakeyroc3 snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this issue Dec 17, 2012
@MikeMcQuaid MikeMcQuaid Add sbcl bottle.
Result of discussion in #9841.
74b21c3
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.