Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
removing libiconv duplicate #10464
libiconv ships with OS X. A few build scripts have/used to have trouble detecting it correctly, so it was added as a formula. Then some other formulas, seeing that it was there, started using it as a dependency, even though they are capable of using the system libiconv.
The first commit patches all formulas that currently
The second commit removes the
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
Probably the easiest way to move this forward is to (a) phase out the existing libiconv dependency declarations from formula that grew them spuriously, (b) wait a week or two to in case any weird issues pop up, and then finally (c) remove the libiconv formula.
For example, the zsh formula gained its libiconv dep for no apparent reason recently (IOW, there wasn't any comments or discussion about it that I could find) so I am comfortable removing it now.