Updated notmuch formula to make use of Emacs.app or Aquamacs.app. #10643

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@controesempio

I've read Homebrew/legacy-homebrew#3568 and I tried to find a different solution to the problem.

The situation is: the emacs version wich ships with OSX is version 22, while the elisp frontend for notmuch (wich comes with the source) need json.el wich has been included in emacs version 23.

My proposed solution is: give user the option to use Emacs.app, Aquamacs.app or the Homebrew version of Emacs, but don't install the lisp code by default. This should be consistent with the current formula (which doesn't install any lisp code), and doesn't add any dependencies.

@adamv

The user may have installed the .app into ~/Applications instead of the system folder.

@controesempio

That's right, but is there a way to give optional arguments to a formula trough the command line (something like "--emacs [App location])? I don't think it's a good way to hard-code all the possible locations where an Emacs.app could be...

The current formula is missing a pretty much fundamental part of the notmuch package. If the command like option is not viable, I can investigate the solution proposed in #3568 (which look abandoned), i.e. putting the missing files for emacs 22 and try to make OSX default emacs use them.

@controesempio

I've patched notmuch to compile with emacs22. This should resolve the problems related to finding if there is a newer version of emacs on the system.

brew audit complains about "Using raw GitHub URLs is not recommended". I've put the patches in Gist, and I've seen other people doing it. Is this wrong? Even the installation URL for Homebrew is Gist raw URL.

And I've updated the name of libnotmuch library. It must have been overlooked when the last version of notmuch was pulled into Homebrew.

@jacknagel

brew audit complains about "Using raw GitHub URLs is not recommended". I've put the patches in Gist, and I've seen other people doing it. Is this wrong? Even the installation URL for Homebrew is Gist raw URL.

We try to avoid external patches when possible. If we don't control them, they can disappear without warning. Would upstream consider these patches?

@controesempio

I will try to report them upstream and see what happens.

@brabalan

I couldn't wait for this patch to go through, so I added a simple '--with-emacs' option that compiles with the Homebrew emacs. The commit is here brabalan@702c825 but I don't know how to add it to this issue.

@adamv

@brabalan if you could open a separate pull request that would be great

@adamv adamv was assigned Nov 3, 2012
@brabalan

adamv: I just created a pull request (#15895). As it's the first time I'm doing this, please let me know if I did not do it correctly.

@adamv

Closing in favor of updated request in #15895 - will follow up there.

@adamv adamv closed this Jan 1, 2013
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.