Add --HEAD for libogg and libvorbis #11146

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@richo
richo commented Mar 22, 2012

Let me know if this should be 2 PR's, I figure since they're linked
they're more or less one.

@mistydemeo mistydemeo and 1 other commented on an outdated diff Mar 22, 2012
Library/Formula/libogg.rb
def install
+ if ARGV.build_head?
+ system "./autogen.sh"
@mistydemeo
mistydemeo Mar 22, 2012 collaborator

If this is running autogen.sh, probably needs to depend on automake/autoconf when building head in Xcode 4.3, since it no longer includes those tools.

@richo
richo Mar 22, 2012

Thanks, I would have had them installed anyway. I'm an idiot.. I was actually just looking at another repo that does that. I'll rebase and push again.

@richo
richo commented Mar 22, 2012

Thanks for the feedback @mistydemeo.

I rebased the commits to include automake and libtool when using new Xcode.

@mistydemeo mistydemeo commented on an outdated diff Mar 22, 2012
Library/Formula/libvorbis.rb
depends_on 'pkg-config' => :build
depends_on 'libogg'
+ if ARGV.build_head? and MacOS.xcode_version >= "4.3"
+ depends_on "automake" => :build
+ depends_on "libtool" => :build
@mistydemeo
mistydemeo Mar 22, 2012 collaborator

Check your indentation here. ;)

@mistydemeo
Collaborator

Thanks! The Xcode 4.3 stuff is still pretty new so it catches a lot of people off-guard.

@richo
richo commented Mar 22, 2012

Good catch. My editor did something weird but I screwed up the cleanup.

Yet another rebase and force push complete :)

@mistydemeo
Collaborator

OK, gave it a run.

Looks like libogg refuses to run with the version of automake shipped with pre-Xcode 4.3, so I think the automake dep is going to have to be used on all systems. libtool can remain an Xcode 4.3-only dep.

The libogg and libvorbis autogen.sh run autoheader, which comes with autoconf - if that's necessary autoconf may also need to be added as an Xcode 4.3 dep. I need to give this a test on my 4.3 box later today.

libvorbis builds fine with automake/autoconf from older Xcodes.

@richo
richo commented Mar 22, 2012

Thanks @mistydemeo .

Is there an automated way to get a "clean" environment to test this in? I was thinking a second homebrew with a different prefix?

It bothers me that you had to spend time testing this.

@richo richo Add --HEAD for libogg and libvorbis
Refactor dependencies for 4.3 sanity
5df2d8d
@richo
richo commented Apr 8, 2012

I bumped this patch, should be ok now I think.

@Sharpie Sharpie added a commit that closed this pull request Apr 22, 2012
@richo richo libogg, libvorbis: Add --HEAD
Closes #11146.

Signed-off-by: Charlie Sharpsteen <source@sharpsteen.net>
b599717
@Sharpie Sharpie closed this in b599717 Apr 22, 2012
@Sharpie
Sharpie commented Apr 22, 2012

Tested and pulled. Thanks!

@rohansingh rohansingh added a commit to rohansingh/homebrew that referenced this pull request May 7, 2012
@richo richo libogg, libvorbis: Add --HEAD
Closes #11146.

Signed-off-by: Charlie Sharpsteen <source@sharpsteen.net>
15b8aa1
@Sharpie Sharpie added a commit to Sharpie/homebrew that referenced this pull request Sep 12, 2012
@richo richo libogg, libvorbis: Add --HEAD
Closes #11146.

Signed-off-by: Charlie Sharpsteen <source@sharpsteen.net>
b04091e
@snakeyroc3 snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this pull request Dec 17, 2012
@richo richo libogg, libvorbis: Add --HEAD
Closes #11146.

Signed-off-by: Charlie Sharpsteen <source@sharpsteen.net>
b921816
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.