brew tap --force #11565

Closed
wants to merge 1 commit into from

4 participants

@staticfloat

Add ability to "--force" when installing a tap, thus allowing for a "retap", in the event that formulae have been added/changed.

My use case: when I added the openblas and lapack formulae in my topic branch of homebrew-dupes, I had to retap staticfloat/dupes in order to get symlinks from the tap into Library/Formula/.

@staticfloat staticfloat Add ability to "--force" when linking a tap, thus allowing for a "ret…
…ap" of a repo, in the event that formulae have been added/changed.

My use case: when I added the openblas and lapack formulae in my topic branch of homebrew-dupes, I had to retap in order to get symlinks from the tap into Library/Formula/
6efc115
@jacknagel

Doesn't brew update take care of adding new symlinks?

@staticfloat

brew update does not symlink from the Taps into Library/Formula/ for me.

@jacknagel

Oh I see the issue. In the normal case brew update does indeed symlink added formulae. But because you had updated your tap locally, brew update didn't know about the additions.

@staticfloat

I see, it automatically pulls and re-symlinks..... but it also only operates on master (and also switches to master which is strange behavior, I'd say), it doesn't preserve your choice of topic branch.

@jacknagel

I see value in having a way to walk a given tap and add/remove symlinks independently of brew update, not sure that I'd call it brew tap --force, though.

and also switches to master which is strange behavior, I'd say

Perhaps, but it's too late to change it now ;) The existing userbase now has the right to expect that brew update won't merge into their topic branches, so altering the behavior would be a breaking change.

@staticfloat

As an exercise to both learn ruby and homebrew better, I wouldn't mind taking a shot at writing something like this. Were you thinking some way to manipulate the symlinks on a Formula by Formula basis, or functionality similar to what I proposed earlier? (e.g. a brew retap or somesuch). I'd hazard a guess that brew untap solves the removing symlinks problem.

@jacknagel

Were you thinking some way to manipulate the symlinks on a Formula by Formula basis, or functionality similar to what I proposed earlier?

The latter, it should be an "all or nothing" type thing.

@mxcl Yielding to your judgement here; I think this would be a good thing to have, but I don't really have a feel for where it fits into the UI.

@mxcl
Homebrew member

--force is not the right switch I think, since this would imply it should clone again, since this is a key part of the tap command. Maybe something like --no-clone, though I don't particularly like that.

Regarding update switching branch, open a new ticket. Thanks.

@mxcl
Homebrew member

I can't really see any reason not to just do the symlink step if the clone is already there as part of the standard tap command really.

@staticfloat

I agree, just didn't want to change existing functionality

@nox

brew update doesn't symlink new formulae here.

@mxcl mxcl added a commit that closed this pull request Aug 4, 2012
@mxcl mxcl `brew tap --repair`
Removes dead symlinks in Formula and re-symlinks all Taps.

Closes #11565.
5eb06b9
@mxcl mxcl closed this in 5eb06b9 Aug 4, 2012
@hmac hmac added a commit that referenced this pull request Aug 8, 2012
@mxcl mxcl `brew tap --repair`
Removes dead symlinks in Formula and re-symlinks all Taps.

Closes #11565.
3ce2f7f
@Sharpie Sharpie pushed a commit to Sharpie/homebrew that referenced this pull request Aug 13, 2012
@mxcl mxcl `brew tap --repair`
Removes dead symlinks in Formula and re-symlinks all Taps.

Closes #11565.
22818c0
@fgeller fgeller added a commit to fgeller/homebrew that referenced this pull request Aug 22, 2012
@mxcl mxcl `brew tap --repair`
Removes dead symlinks in Formula and re-symlinks all Taps.

Closes #11565.
dbae6b6
@Nexuapex Nexuapex pushed a commit that referenced this pull request Aug 29, 2012
@mxcl mxcl `brew tap --repair`
Removes dead symlinks in Formula and re-symlinks all Taps.

Closes #11565.
0dcb869
@ckdaas ckdaas added a commit that referenced this pull request Sep 10, 2012
@mxcl mxcl `brew tap --repair`
Removes dead symlinks in Formula and re-symlinks all Taps.

Closes #11565.
d1c76ac
@snakeyroc3 snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this pull request Dec 17, 2012
@mxcl mxcl `brew tap --repair`
Removes dead symlinks in Formula and re-symlinks all Taps.

Closes #11565.
ac96371
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.