avro-c: Update to the installer to support asciidoc #11828

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

gregvirgin commented Apr 23, 2012

Updated to include HTML docs. NOTE: if xz is present on the system, it must be compiled --universal. Changes must be made to the avro-c package to avoid this if necessary.

gregvirgin added some commits Apr 20, 2012

@gregvirgin gregvirgin Updated avro-c to 1.6.3 b42aad8
@gregvirgin gregvirgin Updates to the installer. This adds an option to include asciidoc. Th…
…ere may be

issues if xz is present on the system, as it will try to link to a non-
universal lzma library, but installing xz with --universal fixes the problem.
eead514
Contributor

adamv commented Apr 23, 2012

Please include the formula name in the pull request title, thanks.

Can't leave commented-out code in here like this.

Contributor

gregvirgin commented Apr 23, 2012

Fixed.

@jacknagel jacknagel commented on the diff May 19, 2012

Library/Formula/avro-c.rb
depends_on 'cmake' => :build
+ depends_on 'xz'
+ depends_on 'asciidoc' if ARGV.include? '--asciidoc'
@jacknagel

jacknagel May 19, 2012

Contributor

Mark this as a build-time dep: depends_on 'asciidoc' => :build if ...

@jacknagel jacknagel commented on the diff May 19, 2012

Library/Formula/avro-c.rb
depends_on 'cmake' => :build
+ depends_on 'xz'
+ depends_on 'asciidoc' if ARGV.include? '--asciidoc'
+
+ def options
+ [
+ ['--asciidoc', "Enable HTML documentation"],
@jacknagel

jacknagel May 19, 2012

Contributor

Maybe the option should be named "--with-html-docs" or something?

@jacknagel jacknagel commented on the diff May 19, 2012

Library/Formula/avro-c.rb
def install
- system "cmake #{std_cmake_parameters} ."
+ args = std_cmake_parameters.split + [
+ '.',]
+ system "cmake", *args
@jacknagel

jacknagel May 19, 2012

Contributor

This seems to be an unnecessary change.

Contributor

jacknagel commented May 19, 2012

Squash to a single commit please.

Contributor

adamv commented Jun 9, 2012

Pulled an alternate avro-c update.

adamv closed this Jun 9, 2012

xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.