This repository has been archived by the owner. It is now read-only.

Update tiger-vnc to 1.2.0. #11895

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

RuiPereira commented Apr 26, 2012

Now using cmake, libjpeg-turbo and (optionally) gnutls.

Depends on libjpeg-turbo (#11894)

Contributor

RuiPereira commented Jul 2, 2012

Now that #11894 is closed we can update tiger-vnc. No more patching, just do as the developers intended and only install vncviewer in OS X.

Contributor

2bits commented Jul 2, 2012

I spent the last couple of hours working this up before I searched and found this. Feel free to use any of it or none of it. Personally I think that Homebrew is international enough to support NLS.

require 'formula'

class TigerVnc < Formula
  homepage 'http://tigervnc.org/'
  url 'http://downloads.sourceforge.net/project/tigervnc/tigervnc/1.2.0/tigervnc-1.2.0.tar.gz'
  sha1 '0542b2549a85b6723deebc3b5ecafa4f1fbee8e6'

  depends_on 'cmake' => :build
  depends_on 'jpeg-turbo'
  depends_on 'gettext'
  depends_on 'gnutls'
  depends_on :x11

  def install
    gettext = Formula.factory('gettext')
    turbo   = Formula.factory('jpeg-turbo')
    args = std_cmake_args + %W[
      -DJPEG_INCLUDE_DIR=#{turbo.include}
      -DJPEG_LIBRARY=#{turbo.lib}/libjpeg.dylib
      -DCMAKE_PREFIX_PATH=#{gettext.prefix}
      .
    ]
    system 'cmake', *args
    system 'make install'
    mv (prefix+'man'), share
  end
end
Contributor

RuiPereira commented Jul 2, 2012

@2bits: thanks, I'm using your code which is way better than mine was.

Contributor

mistydemeo commented Jul 4, 2012

Looks good, thanks! Can you squash these down to a single commit?

Library/Formula/tiger-vnc.rb
- end
+ depends_on 'cmake' => :build
+ depends_on 'jpeg-turbo'
+ depends_on 'gnutls' => :recommended
@mistydemeo

mistydemeo Jul 4, 2012

Contributor

I completely forgot we had a :recommended.

I see you have gnutls listed twice.

@mistydemeo

mistydemeo Jul 4, 2012

Contributor

Thanks!

Stylistic nit, but I'd prefer to group fat arrow dependencies into their own groups rather than stick them between standard deps, e.g.

depends_on 'cmake' => :build
depends_on 'gnutls' => :recommended
depends_on 'jpeg-turbo'
depends_on 'gettext'
depends_on :x11
Contributor

RuiPereira commented Jul 4, 2012

Fixed duplicate depends_on and rebased.

Update tiger-vnc to 1.2.0.
Now using cmake, libjpeg-turbo and (optionally) gnutls.
Contributor

RuiPereira commented Jul 4, 2012

Done :)

@mistydemeo mistydemeo closed this in 8de5bd8 Jul 5, 2012

Contributor

mistydemeo commented Jul 5, 2012

Pulled, sorry for the delay! Thanks!

mroderick added a commit to mroderick/homebrew that referenced this pull request Jul 5, 2012

Update tiger-vnc to 1.2.0.
Now using cmake, libjpeg-turbo and (optionally) gnutls.

Closes #11895.

Signed-off-by: Misty De Meo <mistydemeo@gmail.com>

eproxus added a commit to eproxus/homebrew that referenced this pull request Jul 18, 2012

Update tiger-vnc to 1.2.0.
Now using cmake, libjpeg-turbo and (optionally) gnutls.

Closes #11895.

Signed-off-by: Misty De Meo <mistydemeo@gmail.com>

Sharpie pushed a commit to Sharpie/homebrew that referenced this pull request Sep 12, 2012

Update tiger-vnc to 1.2.0.
Now using cmake, libjpeg-turbo and (optionally) gnutls.

Closes #11895.

Signed-off-by: Misty De Meo <mistydemeo@gmail.com>

snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this pull request Dec 17, 2012

Update tiger-vnc to 1.2.0.
Now using cmake, libjpeg-turbo and (optionally) gnutls.

Closes #11895.

Signed-off-by: Misty De Meo <mistydemeo@gmail.com>

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.