This repository has been archived by the owner. It is now read-only.

mpg123 1.14.1 and adjust formula #12149

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

2bits commented May 8, 2012

  • Upgrade mpg123 to 1.14.0.
  • Remove skip clean. Use --with-module-suffix=.so instead.
  • Remove --with-audio list. It builds coreaudio, openal, dummy.
  • Remove LDFLAGS inreplace that added read-only-relocs,suppress.

Mpg123 builds output modules using the .so suffix by default.
So let it load them with that name. Tested by playing mp3s.
Also let it build the modules it wants to build. Someone
may desire that functionality. The read-only-relocs inreplace
was removed because that is not valid on x86_64. It generates
warnings. @mxcl asked in a comment why it was there.
It may be needed for 32bit SL or Leopard. There was nothing
in the history or past issues that explained adding that.
The --with-cpu flags are still needed.
This compiles on Lion with clang and llvm from XCode-4.3.2.

nibbles 2bits
mpg123 1.14.1 and adjust formula
* Upgrade mpg123 to 1.14.0.
* Remove skip clean. Use --with-module-suffix=.so instead.
* Remove --with-audio list. It builds coreaudio, openal, dummy.
* Remove LDFLAGS inreplace that added read-only-relocs,suppress.

Mpg123 builds output modules using the .so suffix by default.
So let it load them with that name. Tested by playing mp3s.
Also let it build the modules it wants to build. Someone
may desire that functionality. The read-only-relocs inreplace
was removed because that is not valid on x86_64. It generates
warnings.  @mxcl asked in a comment why it was there.
It may be needed for 32bit SL or Leopard.  There was nothing
in the history or past issues that explained adding that.
The `--with-cpu` flags are still needed.
This compiles on Lion with clang and llvm from XCode-4.3.2.
Contributor

jacknagel commented May 9, 2012

Thanks.

@jacknagel jacknagel closed this in d8b8619 May 9, 2012

Sharpie pushed a commit to Sharpie/homebrew that referenced this pull request Sep 12, 2012

mpg123 1.14.1
* Upgrade mpg123 to 1.14.0.
* Remove skip clean. Use --with-module-suffix=.so instead.
* Remove --with-audio list. It builds coreaudio, openal, dummy.
* Remove LDFLAGS inreplace that added read-only-relocs,suppress.

Mpg123 builds output modules using the .so suffix by default.
So let it load them with that name. Tested by playing mp3s.
Also let it build the modules it wants to build. Someone
may desire that functionality. The read-only-relocs inreplace
was removed because that is not valid on x86_64. It generates
warnings.  @mxcl asked in a comment why it was there.
It may be needed for 32bit SL or Leopard.  There was nothing
in the history or past issues that explained adding that.
The `--with-cpu` flags are still needed.
This compiles on Lion with clang and llvm from XCode-4.3.2.

Closes #12149.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this pull request Dec 17, 2012

mpg123 1.14.1
* Upgrade mpg123 to 1.14.0.
* Remove skip clean. Use --with-module-suffix=.so instead.
* Remove --with-audio list. It builds coreaudio, openal, dummy.
* Remove LDFLAGS inreplace that added read-only-relocs,suppress.

Mpg123 builds output modules using the .so suffix by default.
So let it load them with that name. Tested by playing mp3s.
Also let it build the modules it wants to build. Someone
may desire that functionality. The read-only-relocs inreplace
was removed because that is not valid on x86_64. It generates
warnings.  @mxcl asked in a comment why it was there.
It may be needed for 32bit SL or Leopard.  There was nothing
in the history or past issues that explained adding that.
The `--with-cpu` flags are still needed.
This compiles on Lion with clang and llvm from XCode-4.3.2.

Closes #12149.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.