This repository has been archived by the owner. It is now read-only.

New formula: fsbext 0.3 #12703

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@jkap

jkap commented Jun 9, 2012

Found at http://aluigi.altervista.org/papers.htm

Compilation on Mac requires a patch due to the source hardcoding stricmp.

@adamv

This comment has been minimized.

Show comment Hide comment
@adamv

adamv Jun 9, 2012

Contributor

What does this software do?

Contributor

adamv commented Jun 9, 2012

What does this software do?

@jacknagel

This comment has been minimized.

Show comment Hide comment
@jacknagel

jacknagel Jun 9, 2012

Contributor

Has the patch been sent upstream? Also it is small enough that it can be inlined.

Contributor

jacknagel commented Jun 9, 2012

Has the patch been sent upstream? Also it is small enough that it can be inlined.

@jkap

This comment has been minimized.

Show comment Hide comment
@jkap

jkap Jun 9, 2012

@adamv It's software for extracting audio from FSB files, frequently used in video games. It's necessary for audio modding for these games.

@jacknagel As far as I can tell, the original developer isn't accepting changes to the code.

I've inlined the patch in a squashed commit.

jkap commented Jun 9, 2012

@adamv It's software for extracting audio from FSB files, frequently used in video games. It's necessary for audio modding for these games.

@jacknagel As far as I can tell, the original developer isn't accepting changes to the code.

I've inlined the patch in a squashed commit.

+
+class Fsbext < Formula
+ homepage 'http://aluigi.altervista.org/papers.htm'
+ url 'https://dl.dropbox.com/u/14604/fsbext.zip'

This comment has been minimized.

Show comment Hide comment
@jacknagel

jacknagel Aug 28, 2012

Contributor

We can't really have things hosted on people's dropboxes. Also, the URL has to be versioned to prevent breakages if the package is updated.

@jacknagel

jacknagel Aug 28, 2012

Contributor

We can't really have things hosted on people's dropboxes. Also, the URL has to be versioned to prevent breakages if the package is updated.

+ version '0.3'
+
+ def install
+ system "gcc fsbext.c -o fsbext"

This comment has been minimized.

Show comment Hide comment
@jacknagel

jacknagel Aug 28, 2012

Contributor

Can't hardcode the compiler like this.

system ENV.cc, "fsbext.c", "-o", "fsbext"
@jacknagel

jacknagel Aug 28, 2012

Contributor

Can't hardcode the compiler like this.

system ENV.cc, "fsbext.c", "-o", "fsbext"
+ def patches
+ # fixes strcasecmp
+ DATA
+ end

This comment has been minimized.

Show comment Hide comment
@jacknagel

jacknagel Aug 28, 2012

Contributor

patches goes above install.

@jacknagel

jacknagel Aug 28, 2012

Contributor

patches goes above install.

+
+ def test
+ system "which fsbext"
+ end

This comment has been minimized.

Show comment Hide comment
@jacknagel

jacknagel Aug 28, 2012

Contributor

Pointless test, either make it test the software or just remove it.

@jacknagel

jacknagel Aug 28, 2012

Contributor

Pointless test, either make it test the software or just remove it.

@adamv

This comment has been minimized.

Show comment Hide comment
@adamv

adamv Sep 3, 2012

Contributor

Rejecting as we don't like packaging things that have unversioned downloads. Perhaps the author could post the source to GitHub or other hosting site, and provide versions.

Contributor

adamv commented Sep 3, 2012

Rejecting as we don't like packaging things that have unversioned downloads. Perhaps the author could post the source to GitHub or other hosting site, and provide versions.

@adamv adamv closed this Sep 3, 2012

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.