This repository has been archived by the owner. It is now read-only.

Universal support for gdbm, graphviz, and udis86 #12922

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

mrjbq7 commented Jun 19, 2012

Adding universal support to gdbm, graphviz, and udis86.

Is this something that should be added to each formula, or can this option be supported at a higher level?

Owner

MikeMcQuaid commented Jun 19, 2012

What you've done is already implicit (I'm 99% sure, will wait for one of the others to correct me if wrong).

Contributor

adamv commented Jun 19, 2012

@MikeMcQuaid nope, --universal needs to be added to each formula independently. We don't want to appear to support universal builds for things that either don't build correctly or require more complicated steps.

Owner

MikeMcQuaid commented Jun 19, 2012

Adding --universal or another random option doesn't actually provide any special output though, right? I don't see a disadvantage in making that implicit or generally reducing boilerplate.

Owner

MikeMcQuaid commented Jun 19, 2012

Because unless I'm mistaken all that would happen now is it would silently not build universally.

Contributor

jacknagel commented Jun 19, 2012

Even though brew install does not whine about unknown options, I think we should continue to be explicit, both on principle and because we will need some way of knowing whether or not a formula can do a universal build for eventual depends_on 'foo' => :universal support, anyway.

Owner

MikeMcQuaid commented Jun 19, 2012

Fair enough dudes.

Contributor

mrjbq7 commented Jun 20, 2012

If more than half the formulas can be built universal, wouldn't it be better to reverse this (e.g., make "universal" the default and add "not universal" to the formula files)?

Contributor

adamv commented Jun 23, 2012

Pulled gdbm and udis86, since they have no deps, but not GraphViz. It depends on pango (apparently), which we are not currently building universal.

Please open a new pull request just for GraphViz.

@adamv adamv closed this Jun 23, 2012

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.