QEMU: #13345

Closed
wants to merge 1 commit into
from

8 participants

@trynity
@2bits

Awesome. Thanks for tracking this down. Does the head build have a configure without using autoconf? On my phone so I can't tell.

@trynity

It does, thankfully.

@2bits

Could you modify the title of this issue and the commit message title to be something more descriptive that QEMU: One suggestion would be

qemu: add head, fix for clang
@trynity

Ah, fair enough. I'm still working through how to nicely format git messages. Even after using it for a year. Updated the commit.

Tryn Mirell QEMU: Add HEAD; Fix for clang
* Add git HEAD
* Allow compilation with clang by enabling TCG Interpreter
  (See https://bugs.launchpad.net/qemu/+bug/996303)
5fd0bf7
@2bits

@mistydemeo want to review? It works for me.

@mistydemeo mistydemeo commented on the diff Jul 13, 2012
Library/Formula/qemu.rb
@@ -21,6 +18,7 @@ def install
--cc=#{ENV.cc}
--host-cc=#{ENV.cc}
--enable-cocoa
+ --enable-tcg-interpreter
@mistydemeo
mistydemeo added a line comment Jul 13, 2012

Would you mind adding a comment with a link to the upstream issue and an explanation of why this was added?

@Sharpie
Sharpie added a line comment Sep 18, 2012

Indeed. We need this info in order to commit the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@mistydemeo

Looks good. Question though - is there a performance hit when using the TCG interpreter? Would it be beneficial to turn that option off when building with compilers that work without it?

@adamv

Ping.

@adamv

Went to 1.2.0 in 2ed8940 and it builds with build 421.

@adamv adamv closed this Sep 7, 2012
@Sharpie

This could sill be an issue: #14936.

@Sharpie

Re-opening due to #14936.

@Sharpie Sharpie reopened this Sep 18, 2012
@adamv adamv referenced this pull request Oct 2, 2012
Closed

qemu 1.2.0 fails to compile #14936

@kevinbirch

Performance of the TCG interpreter is abismal, and shouldn't be considered as a solution to this issue. As I mentioned in #14936, gcc will compile QEMU and not harm performance.

@adamv

Mountain Lion's Xcode doesn't come with GCC. Suggestions?

@kevinbirch

For folks upgrading Xcode and MacOS from earlier versions should still have it. For fresh ML installs, they should install it themselves. There is a lot of discussion about how to do this (e.g. http://caiustheory.com/install-gcc-421-apple-build-56663-with-xcode-42). There doesn't seem to be a formula for gcc 4.6, which is too bad.

@MikeMcQuaid
Homebrew member

No, they shouldn't. We (and upstream) need to work with clang long-term or llvm-gcc short-term.

@adamv adamv was assigned Oct 15, 2012
@adamv

Presumably the new version doesn't help here, but can someone check? #16170.

@guillaumekh

1.2.1 builds with llvm-gcc
==> Downloading http://wiki.qemu.org/download/qemu-1.2.1.tar.bz2
######################################################################## 100,0%
==> ./configure --prefix=/usr/local/Cellar/qemu/1.2.1 --cc=llvm-gcc --host-cc=ll
==> make install
/usr/local/Cellar/qemu/1.2.1: 106 files, 77M, built in 3.0 minutes

I have xcode's command line tools installed

@trynity

Yes, the GCC front-end will actually compile the code, but LLVM is not capable of global registers yet, so the resulting code won't work.

@adamv adamv added a commit that closed this pull request Dec 4, 2012
@bovi bovi qemu 1.3.0
Closes #16400.
Fixes #13345.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
be4fa47
@adamv adamv closed this in be4fa47 Dec 4, 2012
@snakeyroc3 snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this pull request Dec 17, 2012
@bovi bovi qemu 1.3.0
Closes #16400.
Fixes #13345.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
fc2463f
@gwydirsam gwydirsam added a commit that referenced this pull request Jan 2, 2013
@bovi bovi qemu 1.3.0
Closes #16400.
Fixes #13345.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
fe3bff6
@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.