This repository has been archived by the owner. It is now read-only.

libxml2: Fix Python bindings for Xcode-only #13511

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

samueljohn commented Jul 20, 2012

  • Help libxml2/python/setup.py to find libiconv headers.
Contributor

samueljohn commented Jul 20, 2012

I had this on my list for a long time, since it was quite hard to fix.

Basically what I found is that when readline, sqlite or any keg-only python dependency gets updated, one should rebuild python so that Python's distutils can update it's internally remembered LDFLAGS. Further, Python remembers the SDKROOT. When you build an extension with pip or by executing a setup.py, these flags will be used.

Contributor

adamv commented Jul 31, 2012

Reference #1824.

Contributor

samueljohn commented Aug 6, 2012

Updated to use  the newer MacOS::CLT.installed?.

@adamv adamv closed this in 202119e Aug 10, 2012

@adamv adamv reopened this Aug 10, 2012

@fgeller fgeller added a commit to fgeller/homebrew that referenced this pull request Aug 22, 2012

@samueljohn @fgeller samueljohn + fgeller libxml2: Fix Python bindings for Xcode-only
- Since libxml2 is a dupe, we have to assure to link against it and not system's python.
- Unless the CLT are present, apply a patch for the linking step.
- Help libxml2/python/setup.py to find libiconv headers.

Closes #13511.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
921b736
Contributor

samueljohn commented Aug 22, 2012

Now, less hacky and more modern. And working on xcode-only systems.

Contributor

samueljohn commented Aug 22, 2012

Because build may succeed but python bindings are still broken, I added a test brew test libxml2 --python.

@Sharpie Sharpie pushed a commit to Sharpie/homebrew that referenced this pull request Sep 12, 2012

@samueljohn @adamv samueljohn + adamv libxml2: Fix Python bindings for Xcode-only
- Since libxml2 is a dupe, we have to assure to link against it and not system's python.
- Unless the CLT are present, apply a patch for the linking step.
- Help libxml2/python/setup.py to find libiconv headers.

Closes #13511.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
86bcfcf
Contributor

samueljohn commented Sep 27, 2012

I'll check that this PR still works nicely with python going superenv.

Contributor

samueljohn commented Oct 8, 2012

Updated this PR. It is very small right now and only needs one fix on NCLT.

One minor question remains: Since this is keg-only, the python module does not get symlinked, too, so users will need to add a path deep in the Cellar to their PYTHONPATH. This sucks.

Do you think it's okay to manually put the symlinks to HOMEBREW_PREFIX/lib/python2.7/site-packages?

Contributor

adamv commented Oct 24, 2012

Maybe "hey, install CLT" is a better solution.

Contributor

samueljohn commented Oct 24, 2012

:-/
we have gone some length to support NCLT now - which is good - why stopping short before the finish line?

Contributor

samueljohn commented Nov 9, 2012

❄️ ❄️ ❄️ ... it's getting winter.

Contributor

samueljohn commented Nov 22, 2012

ping

Contributor

samueljohn commented Dec 3, 2012

@Sharpie may I ask you to pull this? Is only a small change and its guarded to be only applied on Xcode-only system.

Contributor

jacknagel commented Dec 8, 2012

Pulled

@jacknagel jacknagel closed this in bdfb90b Dec 8, 2012

@snakeyroc3 snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this pull request Dec 17, 2012

@samueljohn @adamv samueljohn + adamv libxml2: Fix Python bindings for Xcode-only
- Since libxml2 is a dupe, we have to assure to link against it and not system's python.
- Unless the CLT are present, apply a patch for the linking step.
- Help libxml2/python/setup.py to find libiconv headers.

Closes #13511.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
8eacbd3

@snakeyroc3 snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this pull request Dec 17, 2012

@samueljohn @jacknagel samueljohn + jacknagel libxml2: Python bindings find libiconv on NCLT.
Closes #13511.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
fd088b8

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.