This repository has been archived by the owner. It is now read-only.

lilypond: add devel block & python requirement #13513

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@2bits
Contributor

2bits commented Jul 20, 2012

Add a devel block for Lilypond so that people can test out the
current release candidate.

Add a fails_with :clang block due to C99 pointer errors.

Add a Requirement that Python be compiled with --use-llvm so
that Lilypond and Python both will be compiled with llvm to solve
a build error where Lilypond uses both its own cflags and the
ones from Python.

Add a def test to produce some output in a pdf that is displayed
with qlmanage.

This doesn't work atm because I need to find a way to test if Python
was compiled with --use-llvm but trying to query that from Tab doesn't work.

@2bits

This comment has been minimized.

Show comment Hide comment
@2bits

2bits Jul 24, 2012

Contributor

@samueljohn how do I test an instance of python to see if it was compiled with llvm-gcc?

Contributor

2bits commented Jul 24, 2012

@samueljohn how do I test an instance of python to see if it was compiled with llvm-gcc?

@jacknagel

This comment has been minimized.

Show comment Hide comment
@jacknagel

jacknagel Jul 24, 2012

Contributor

Can we find some way to adjust the flags that are being obtained from python (presumably from python-config)? It seems pretty unfriendly to force Python to be built with a specific compiler to make this work.

Contributor

jacknagel commented Jul 24, 2012

Can we find some way to adjust the flags that are being obtained from python (presumably from python-config)? It seems pretty unfriendly to force Python to be built with a specific compiler to make this work.

@samueljohn

View changes

Library/Formula/lilypond.rb
+class PythonCompilerIsLLVM < Requirement
+ def message
+ <<-EOS.undent
+ Lilypond has an issue where it mixes compile flags with Python. So both

This comment has been minimized.

Show comment Hide comment
@samueljohn

samueljohn Jul 24, 2012

Contributor

You do these ugly two-spaces-after-period thingy? g

@samueljohn

samueljohn Jul 24, 2012

Contributor

You do these ugly two-spaces-after-period thingy? g

This comment has been minimized.

Show comment Hide comment
@2bits

2bits Jul 24, 2012

Contributor

My mom taught me to use two space spaces when I was a child, or she would take away my cigarettes.

@2bits

2bits Jul 24, 2012

Contributor

My mom taught me to use two space spaces when I was a child, or she would take away my cigarettes.

This comment has been minimized.

Show comment Hide comment
@samueljohn

samueljohn Jul 24, 2012

Contributor

haha ^^ but still

@samueljohn

samueljohn Jul 24, 2012

Contributor

haha ^^ but still

@samueljohn

This comment has been minimized.

Show comment Hide comment
@samueljohn

samueljohn Jul 24, 2012

Contributor

@2bits I don't know. import sysconfig; sysconfig.get_config_var('MAINCC') points to the clang executable inside of Xcode on my xcode-only system. But I agree with @jacknagel that we should try harder to find another solution.
I'll look into it.

Contributor

samueljohn commented Jul 24, 2012

@2bits I don't know. import sysconfig; sysconfig.get_config_var('MAINCC') points to the clang executable inside of Xcode on my xcode-only system. But I agree with @jacknagel that we should try harder to find another solution.
I'll look into it.

@2bits

This comment has been minimized.

Show comment Hide comment
@2bits

2bits Jul 24, 2012

Contributor
>>> import sysconfig; sysconfig.get_config_var('MAINCC')
'/usr/bin/llvm-gcc'
>>> 

So that's good. I'll fix the formula, and I'll report the clang problems to Lilypond developers. Though I would also prefer not to impose this Requirement, it is a way that works to get people their program in a pull request, while I work out the upstream cflags problems.

Yes, Jack, that would be preferable, I agree, to fix their mixing python cflags. I don't think I'm comfortable trying to patch their --devel, though. I'll just politely try to ask them what's up with that, and I'll send them a Kenan Thompson link.

Contributor

2bits commented Jul 24, 2012

>>> import sysconfig; sysconfig.get_config_var('MAINCC')
'/usr/bin/llvm-gcc'
>>> 

So that's good. I'll fix the formula, and I'll report the clang problems to Lilypond developers. Though I would also prefer not to impose this Requirement, it is a way that works to get people their program in a pull request, while I work out the upstream cflags problems.

Yes, Jack, that would be preferable, I agree, to fix their mixing python cflags. I don't think I'm comfortable trying to patch their --devel, though. I'll just politely try to ask them what's up with that, and I'll send them a Kenan Thompson link.

nibbles 2bits
lilypond: add devel block & python requirement
Add a devel block for Lilypond so that people can test out the
current release candidate.

Add a `fails_with :clang` block due to C99 pointer errors.

Add a Requirement that HB Python be compiled with `--use-llvm` so
that Lilypond and Python both will be compiled with llvm to solve
a build error where Lilypond uses both its own `cflags` and the
ones from Python.

Add a `def test` to produce some output in a pdf that is displayed
with `qlmanage`.

Tested against System Python and Homebrew Framework Python built
with llvm on Lion using XCode-4.3.3.
@2bits

This comment has been minimized.

Show comment Hide comment
@2bits

2bits Aug 5, 2012

Contributor

Well I made it work, the requirement for non-clang HB python, but I'm still working on how to fix the CFLAGS instead. Once I figure that out, I'll report this upstream and change the PR to fix the CFLAGS not require an llvm compiled python.

Contributor

2bits commented Aug 5, 2012

Well I made it work, the requirement for non-clang HB python, but I'm still working on how to fix the CFLAGS instead. Once I figure that out, I'll report this upstream and change the PR to fix the CFLAGS not require an llvm compiled python.

@2bits

This comment has been minimized.

Show comment Hide comment
@2bits

2bits Aug 26, 2012

Contributor

I'm closing this because I lost the branch and need to make some changes.

Contributor

2bits commented Aug 26, 2012

I'm closing this because I lost the branch and need to make some changes.

@2bits 2bits closed this Aug 26, 2012

@samueljohn

This comment has been minimized.

Show comment Hide comment
@samueljohn

samueljohn Aug 26, 2012

Contributor

I still have your branch if you are interested.

Contributor

samueljohn commented Aug 26, 2012

I still have your branch if you are interested.

@2bits

This comment has been minimized.

Show comment Hide comment
@2bits

2bits Aug 26, 2012

Contributor

It's ok. They release 2.16.0. So I just have to test it.

Contributor

2bits commented Aug 26, 2012

It's ok. They release 2.16.0. So I just have to test it.

@xu-cheng xu-cheng locked and limited conversation to collaborators Feb 16, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.